Assert all collections on Response types are read only

Reflection unit test traverses IResponse properties to check their types.
Add Fluent Assertions for IReadOnlyDictionary<TKey, TValue>. See dennisdoomen/FluentAssertions#357
Update Watcher APIs to use readonly collections
Use Actions for actions on Watch type
Enable readonly collection deserialization in SimpleJson

(cherry-pick from commit 73a77a2)

Author: russcam

src/Elasticsearch.Net/Responses/ServerError.cs

@@ -82,7 +82,7 @@ public class Error : IRootCause
 		public string ResourceId { get; set; }
 		public string ResourceType { get; set; }
 		public string Type { get; set; }
-		public List<RootCause> RootCause { get; set; }
+		public IReadOnlyCollection<RootCause> RootCause { get; set; }
 		public CausedBy CausedBy { get; set; }
 
 		internal static Error Create(IDictionary<string, object> dict, IJsonSerializerStrategy strategy)
@@ -99,7 +99,7 @@ internal static Error Create(IDictionary<string, object> dict, IJsonSerializerSt
 
 			var os = rootCause as object[];
 			if (os == null) return error;
-			error.RootCause = os.Select(o => (RootCause)strategy.DeserializeObject(o, typeof(RootCause))).ToList();
+			error.RootCause = os.Select(o => (RootCause)strategy.DeserializeObject(o, typeof(RootCause))).ToList().AsReadOnly();
 			return error;
 		}
 

src/Elasticsearch.Net/Serialization/SimpleJson.cs

@@ -32,7 +32,7 @@
 //#define SIMPLE_JSON_DATACONTRACT
 
 // NOTE: uncomment the following line to enable IReadOnlyCollection<T> and IReadOnlyList<T> support.
-//#define SIMPLE_JSON_READONLY_COLLECTIONS
+#define SIMPLE_JSON_READONLY_COLLECTIONS
 
 // NOTE: uncomment the following line to disable linq expressions/compiled lambda (better performance) instead of method.invoke().
 // define if you are using .net framework <= 3.0 or < WP7.5
@@ -81,12 +81,12 @@ namespace Elasticsearch.Net
 		class JsonArray : List<object>
 	{
 		/// <summary>
-		/// Initializes a new instance of the <see cref="JsonArray"/> class. 
+		/// Initializes a new instance of the <see cref="JsonArray"/> class.
 		/// </summary>
 		public JsonArray() { }
 
 		/// <summary>
-		/// Initializes a new instance of the <see cref="JsonArray"/> class. 
+		/// Initializes a new instance of the <see cref="JsonArray"/> class.
 		/// </summary>
 		/// <param name="capacity">The capacity of the json array.</param>
 		public JsonArray(int capacity) : base(capacity) { }
@@ -480,7 +480,7 @@ public override IEnumerable<string> GetDynamicMemberNames()
 	/// <summary>
 	/// This class encodes and decodes JSON strings.
 	/// Spec. details, see http://www.json.org/
-	/// 
+	///
 	/// JSON uses Arrays and Objects. These correspond here to the datatypes JsonArray(IList&lt;object>) and JsonObject(IDictionary&lt;string,object>).
 	/// All numbers are parsed to doubles.
 	/// </summary>
@@ -1176,7 +1176,7 @@ public static DataContractJsonSerializerStrategy DataContractJsonSerializerStrat
 
 #endif
 	}
-    
+
 	[GeneratedCode("simple-json", "1.0.0")]
 #if SIMPLE_JSON_INTERNAL
 	internal
@@ -1289,7 +1289,7 @@ public virtual object DeserializeObject(object value, Type type)
 
 			if (value == null)
 				return null;
-            
+
 			object obj = null;
 
 			if (str != null)
@@ -1327,7 +1327,7 @@ public virtual object DeserializeObject(object value, Type type)
 			}
 			else if (value is bool)
 				return value;
-            
+
 			bool valueIsLong = value is long;
 			bool valueIsDouble = value is double;
 			if ((valueIsLong && type == typeof(long)) || (valueIsDouble && type == typeof(double)))
@@ -2080,4 +2080,4 @@ System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator()
 // ReSharper restore LoopCanBeConvertedToQuery
 // ReSharper restore RedundantExplicitArrayCreation
 // ReSharper restore SuggestUseVarKeywordEvident
-}
+}

src/Nest/Cluster/ClusterReroute/ClusterRerouteState.cs

@@ -17,7 +17,7 @@ public class ClusterRerouteState
 
 		[JsonProperty("nodes")]
 		[JsonConverter(typeof(VerbatimDictionaryKeysJsonConverter<string, NodeState>))]
-		public Dictionary<string, NodeState> Nodes { get; internal set; }
+		public IReadOnlyDictionary<string, NodeState> Nodes { get; internal set; }
 
 		[JsonProperty("routing_table")]
 		public RoutingTableState RoutingTable { get; internal set; }

src/Nest/Cluster/ClusterState/IndexRoutingTable.cs

@@ -7,6 +7,6 @@ public class IndexRoutingTable
 	{
 		[JsonProperty("shards")]
 		[JsonConverter(typeof(VerbatimDictionaryKeysJsonConverter<string, List<RoutingShard>>))]
-		public Dictionary<string, List<RoutingShard>> Shards { get; internal set; }
+		public IReadOnlyDictionary<string, List<RoutingShard>> Shards { get; internal set; }
 	}
 }

src/Nest/Cluster/ClusterState/MetadataState.cs

@@ -9,13 +9,13 @@ public class MetadataState
 	{
 		[JsonProperty("templates")]
 		[JsonConverter(typeof(VerbatimDictionaryKeysJsonConverter<string, TemplateMapping>))]
-		public IDictionary<string, TemplateMapping> Templates { get; internal set; }
+		public IReadOnlyDictionary<string, TemplateMapping> Templates { get; internal set; }
 
 		[JsonProperty("cluster_uuid")]
 		public string ClusterUUID { get; internal set; }
 
 		[JsonProperty("indices")]
 		[JsonConverter(typeof(VerbatimDictionaryKeysJsonConverter<string, MetadataIndexState>))]
-		public Dictionary<string, MetadataIndexState> Indices { get; internal set; }
+		public IReadOnlyDictionary<string, MetadataIndexState> Indices { get; internal set; }
 	}
 }

src/Nest/Cluster/ClusterState/RoutingNodesState.cs

@@ -8,9 +8,9 @@ namespace Nest
 	public class RoutingNodesState
 	{
 		[JsonProperty("unassigned")]
-		public List<RoutingShard> Unassigned { get; internal set; }
+		public IReadOnlyCollection<RoutingShard> Unassigned { get; internal set; }
 
 		[JsonProperty("nodes")]
-		public Dictionary<string, List<RoutingShard>> Nodes { get; internal set; }
+		public IReadOnlyDictionary<string, List<RoutingShard>> Nodes { get; internal set; }
 	}
-}
+}

src/Nest/Cluster/ClusterState/RoutingTableState.cs

@@ -9,6 +9,6 @@ public class RoutingTableState
 	{
 		[JsonProperty("indices")]
 		[JsonConverter(typeof(VerbatimDictionaryKeysJsonConverter<string, IndexRoutingTable>))]
-		public Dictionary<string, IndexRoutingTable> Indices { get; internal set; }
+		public IReadOnlyDictionary<string, IndexRoutingTable> Indices { get; internal set; } = EmptyReadOnly<string, IndexRoutingTable>.Dictionary;
 	}
 }

src/Nest/Cluster/ClusterStats/ClusterNodesStats.cs

@@ -10,7 +10,7 @@ public class ClusterNodesStats
 		public ClusterNodeCount Count { get; internal set; }
 
 		[JsonProperty("versions")]
-		public List<string> Versions { get; internal set; }
+		public IReadOnlyCollection<string> Versions { get; internal set; }
 
 		[JsonProperty("os")]
 		public ClusterOperatingSystemStats OperatingSystem { get; internal set; }
@@ -25,7 +25,7 @@ public class ClusterNodesStats
 		public ClusterFileSystem FileSystem { get; internal set; }
 
 		[JsonProperty("plugins")]
-		public List<PluginStats> Plugins { get; internal set; }
+		public IReadOnlyCollection<PluginStats> Plugins { get; internal set; }
 	}
 
 	[JsonObject]
@@ -55,7 +55,7 @@ public class ClusterJvm
 		public long MaxUptimeInMilliseconds { get; internal set; }
 
 		[JsonProperty("versions")]
-		public List<ClusterJvmVersion> Versions { get; internal set; }
+		public IReadOnlyCollection<ClusterJvmVersion> Versions { get; internal set; }
 
 		[JsonProperty("mem")]
 		public ClusterJvmMemory Memory { get; internal set; }
@@ -139,7 +139,7 @@ public class ClusterOperatingSystemStats
 		public int AllocatedProcessors { get; internal set; }
 
 		[JsonProperty("names")]
-		public List<ClusterOperatingSystemName> Names { get; internal set; }
+		public IReadOnlyCollection<ClusterOperatingSystemName> Names { get; internal set; }
 	}
 
 	[JsonObject]

src/Nest/CommonOptions/Stats/IndexingStats.cs

@@ -44,6 +44,6 @@ public class IndexingStats
 
 		[JsonProperty("types")]
 		[JsonConverter(typeof(VerbatimDictionaryKeysJsonConverter<string, IndexingStats>))]
-		public Dictionary<string, IndexingStats> Types { get; set; }
+		public IReadOnlyDictionary<string, IndexingStats> Types { get; set; }
 	}
 }

src/Nest/Modules/SnapshotAndRestore/Snapshot/Snapshot.cs

@@ -11,46 +11,30 @@ public class Snapshot
 		public string Name { get; internal set;  }
 
 		[JsonProperty("indices")]
-		public IEnumerable<IndexName> Indices { get; internal set; }
+		public IReadOnlyCollection<IndexName> Indices { get; internal set; }
 
 		[JsonProperty("state")]
 		public string State { get; internal set; }
 
 		[JsonProperty("start_time")]
 		public DateTime StartTime { get; internal set;  }
-		
+
 		[JsonProperty("start_time_in_millis")]
 		public long StartTimeInMilliseconds { get; internal set;  }
-		
+
 		[JsonProperty("end_time")]
 		public DateTime EndTime { get; internal set;  }
-		
+
 		[JsonProperty("end_time_in_millis")]
 		public long EndTimeInMilliseconds { get; internal set;  }
-		
+
 		[JsonProperty("duration_in_millis")]
 		public long DurationInMilliseconds { get; internal set;  }
 
 		[JsonProperty("shards")]
 		public ShardsMetaData Shards { get; internal set; }
 
 		[JsonProperty("failures")]
-		public IEnumerable<SnapshotShardFailure> ShardFailures { get; internal set; }
-
-		/// <summary>
-		/// Contains the reason for each shard failure.
-		/// </summary>
-		/// For 2.0, remove this and rename ShardFailures => Failures
-		[JsonIgnore]
-		public IEnumerable<string> Failures
-		{
-			get
-			{
-				if (this.ShardFailures != null) 
-					return this.ShardFailures.Select(f => f.Reason);
-				return new List<string>();
-			}
-		}
-		
+		public IReadOnlyCollection<SnapshotShardFailure> Failures { get; internal set; }
 	}
-}
+}