Skip to content

Update speculative build logic #2200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 14, 2025
Merged

Update speculative build logic #2200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04af1ee
fix speculative build logic
colleenmcginnis Nov 13, 2025
698541a
Check against minor.0 anchored version of product version
Mpdreamz Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/products.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ products:
fleet:
display: 'Fleet'
versioning: 'stack'
fleet-server:
display: 'Fleet Server'
versioning: 'stack'
heartbeat:
display: 'Heartbeat'
versioning: 'stack'
Expand Down
2 changes: 1 addition & 1 deletion src/Elastic.Documentation.Configuration/Assembler/AssemblyConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ public ContentSourceMatch Match(ILoggerFactory logFactory, string repository, st
logger.LogInformation("Current is not using versioned branches checking product info");
var productVersion = versioningSystem.Current;
var previousMinorVersion = new SemVersion(productVersion.Major, Math.Max(productVersion.Minor - 1, 0), 0);
if (v >= productVersion)
if (v.Minor >= productVersion.Minor)
Copy link
Member

@Mpdreamz Mpdreamz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should normalize the product version to Major.Minor this might cause issues if one of the majors differ.

Copy link
Contributor Author

@colleenmcginnis colleenmcginnis Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping in on this!

{
logger.LogInformation("Speculative build {Branch} is gte product current '{ProductCurrent}'", branchOrTag, productVersion);
match = match with
Expand Down
Loading