-
Notifications
You must be signed in to change notification settings - Fork 3
(block-tool-adapter): optimise model listeners count #72
Copy link
Copy link
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Right now each call of the attachInput() lead adding the new event listener to the model. Then, handler will filter-our other inputs.
public attachInput(key: DataKey, input: HTMLElement): void {
// ...
this.#model.addEventListener(EventType.Changed, (event: ModelEvents) => this.#handleModelUpdate(event, input, key, caretAdapter));
}We know that Tool can have many inputs (e.g. Table or Nested List). So it would be better to add a single event listener in the adapter's constructor. And then, find and handle events related to attached inputs.
Probably, we will need to store inputs in a private property.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers