Skip to content

Commit f935f75

Browse files
committed
fix: system_libs is now properly being created in recipes
1 parent 5990b9c commit f935f75

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

ecsact/private/ecsact_binary.bzl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@ def _ecsact_binary_impl(ctx):
109109
outputs = outputs + [temp_dir],
110110
inputs = inputs,
111111
executable = executable,
112+
# 'ecsact build' reads some environment variables for configuration
113+
use_default_shell_env = True,
112114
tools = tools,
113115
arguments = [args],
114116
env = env,

ecsact/private/ecsact_build_recipe.bzl

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ def _ecsact_build_recipe(ctx):
3737
recipe_yaml = ctx.actions.declare_file("{}.yml".format(ctx.attr.name))
3838

3939
sources = []
40-
system_libs = []
4140
recipe_data = []
4241

4342
for src in ctx.files.srcs:
@@ -108,7 +107,7 @@ def _ecsact_build_recipe(ctx):
108107
"name": ctx.attr.name,
109108
"sources": sources,
110109
"imports": ctx.attr.imports,
111-
"system_libs": system_libs,
110+
"system_libs": ctx.attr.system_libs,
112111
"exports": ctx.attr.exports,
113112
}
114113

0 commit comments

Comments
 (0)