Fixed integer comparisons of different signedness.

fdesbiens · fdesbiens · commit 3770e71f132b · 2025-09-29T23:08:42.000+01:00
diff --git a/common/usbx_host_classes/src/ux_host_class_audio_alternate_setting_locate.c b/common/usbx_host_classes/src/ux_host_class_audio_alternate_setting_locate.c
@@ -225,7 +225,7 @@ UINT                                     specific_frequency_count;
                 else
                 {
 
-                    if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (3 * audio_interface_descriptor.bSamFreqType)))
+                    if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (UINT)(3 * audio_interface_descriptor.bSamFreqType)))
                     {
                       return(UX_DESCRIPTOR_CORRUPTED);
                     }
diff --git a/common/usbx_host_classes/src/ux_host_class_audio_raw_sampling_parse.c b/common/usbx_host_classes/src/ux_host_class_audio_raw_sampling_parse.c
@@ -246,7 +246,7 @@ UINT descriptor_length = packed_audio_descriptor[0];
     }
     else
     {
-        if (descriptor_length < (8 + (3 * packed_audio_descriptor[7])))
+        if (descriptor_length < (UINT)(8 + (3 * packed_audio_descriptor[7])))
         {
           /* Error trap. */
           _ux_system_error_handler(UX_SYSTEM_LEVEL_THREAD, UX_SYSTEM_CONTEXT_CLASS, UX_DESCRIPTOR_CORRUPTED);
diff --git a/common/usbx_host_classes/src/ux_host_class_audio_streaming_sampling_get.c b/common/usbx_host_classes/src/ux_host_class_audio_streaming_sampling_get.c
@@ -237,7 +237,7 @@ UINT                                     previous_match_found;
                     else
                     {
 
-                        if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (3 * audio_interface_descriptor.bSamFreqType)))
+                        if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (UINT)(3 * audio_interface_descriptor.bSamFreqType)))
                         {
                           /* Error trap. */
                           _ux_system_error_handler(UX_SYSTEM_LEVEL_THREAD, UX_SYSTEM_CONTEXT_CLASS, UX_DESCRIPTOR_CORRUPTED);
@@ -315,7 +315,7 @@ UINT                                     previous_match_found;
                         else
                         {
 
-                            if (descriptor_length < UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (3 * audio_interface_descriptor.bSamFreqType))
+                            if (descriptor_length < UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (UINT)(3 * audio_interface_descriptor.bSamFreqType))
                             {
                               /* Error trap. */
                               _ux_system_error_handler(UX_SYSTEM_LEVEL_THREAD, UX_SYSTEM_CONTEXT_CLASS, UX_DESCRIPTOR_CORRUPTED);

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ UINT specific_frequency_count;`
`225`	`225`	`else`
`226`	`226`	`{`
`227`	`227`
`228`		`- if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (3 * audio_interface_descriptor.bSamFreqType)))`
	`228`	`+ if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (UINT)(3 * audio_interface_descriptor.bSamFreqType)))`
`229`	`229`	`{`
`230`	`230`	`return(UX_DESCRIPTOR_CORRUPTED);`
`231`	`231`	`}`
Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ UINT descriptor_length = packed_audio_descriptor[0];`
`246`	`246`	`}`
`247`	`247`	`else`
`248`	`248`	`{`
`249`		`- if (descriptor_length < (8 + (3 * packed_audio_descriptor[7])))`
	`249`	`+ if (descriptor_length < (UINT)(8 + (3 * packed_audio_descriptor[7])))`
`250`	`250`	`{`
`251`	`251`	`/* Error trap. */`
`252`	`252`	`_ux_system_error_handler(UX_SYSTEM_LEVEL_THREAD, UX_SYSTEM_CONTEXT_CLASS, UX_DESCRIPTOR_CORRUPTED);`
Original file line number	Diff line number	Diff line change
`@@ -237,7 +237,7 @@ UINT previous_match_found;`
`237`	`237`	`else`
`238`	`238`	`{`
`239`	`239`
`240`		`- if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (3 * audio_interface_descriptor.bSamFreqType)))`
	`240`	`+ if (descriptor_length < (UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (UINT)(3 * audio_interface_descriptor.bSamFreqType)))`
`241`	`241`	`{`
`242`	`242`	`/* Error trap. */`
`243`	`243`	`_ux_system_error_handler(UX_SYSTEM_LEVEL_THREAD, UX_SYSTEM_CONTEXT_CLASS, UX_DESCRIPTOR_CORRUPTED);`
`@@ -315,7 +315,7 @@ UINT previous_match_found;`
`315`	`315`	`else`
`316`	`316`	`{`
`317`	`317`
`318`		`- if (descriptor_length < UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (3 * audio_interface_descriptor.bSamFreqType))`
	`318`	`+ if (descriptor_length < UX_HOST_CLASS_AUDIO_INTERFACE_DESCRIPTOR_LENGTH + (UINT)(3 * audio_interface_descriptor.bSamFreqType))`
`319`	`319`	`{`
`320`	`320`	`/* Error trap. */`
`321`	`321`	`_ux_system_error_handler(UX_SYSTEM_LEVEL_THREAD, UX_SYSTEM_CONTEXT_CLASS, UX_DESCRIPTOR_CORRUPTED);`