Skip to content

Commit c2efbd5

Browse files
committed
update ConfigurationSourceType to provide parameter descriptors
The list of ConfigurationParameterDescriptor replaces the list of QueryParameterKeys. Using just the keys would be too restrictive and ambiguous for clients to implement. see also: eclipse-cdt-cloud/theia-trace-extension#1025 Signed-off-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
1 parent bc62ae1 commit c2efbd5

File tree

2 files changed

+46
-18
lines changed

2 files changed

+46
-18
lines changed

API-proposed.yaml

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,7 @@ paths:
206206
content:
207207
application/json:
208208
schema:
209-
type: array
210-
items:
211-
$ref: '#/components/schemas/ConfigurationSourceType'
209+
$ref: '#/components/schemas/ConfigurationSourceType'
212210
/config/types:
213211
get:
214212
tags:
@@ -2135,17 +2133,33 @@ components:
21352133
to show more details to users of the configuration instance.
21362134
description: Optional informational parameters to return. Can be used to
21372135
show more details to users of the configuration instance.
2136+
ConfigurationParameterDescriptor:
2137+
type: object
2138+
properties:
2139+
dataType:
2140+
type: string
2141+
description: The data type hint of the configuration parameter
2142+
keyName:
2143+
type: string
2144+
description: The unique key name of the configuration parameter
2145+
required:
2146+
type: boolean
2147+
description: A flag indicating whether the configuration parameter is required
2148+
or not
2149+
description:
2150+
type: string
2151+
description: Describes the configuration parameter
2152+
description: A list of configuration parameter descriptors to be passed when
2153+
creating or updating a configuration instance of this type.
21382154
ConfigurationSourceType:
21392155
type: object
21402156
properties:
2141-
queryParameterKeys:
2157+
parameterDescriptors:
21422158
type: array
2143-
description: A list of query parameter keys to be passed when creating configuration
2144-
instance of this type. Use 'path' key for file URIs
2159+
description: A list of configuration parameter descriptors to be passed
2160+
when creating or updating a configuration instance of this type.
21452161
items:
2146-
type: string
2147-
description: A list of query parameter keys to be passed when creating
2148-
configuration instance of this type. Use 'path' key for file URIs
2162+
$ref: '#/components/schemas/ConfigurationParameterDescriptor'
21492163
description:
21502164
type: string
21512165
description: Describes the configuration source type

API.yaml

Lines changed: 23 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,7 @@ paths:
196196
content:
197197
application/json:
198198
schema:
199-
type: array
200-
items:
201-
$ref: '#/components/schemas/ConfigurationSourceType'
199+
$ref: '#/components/schemas/ConfigurationSourceType'
202200
/config/types:
203201
get:
204202
tags:
@@ -1442,17 +1440,33 @@ components:
14421440
to show more details to users of the configuration instance.
14431441
description: Optional informational parameters to return. Can be used to
14441442
show more details to users of the configuration instance.
1443+
ConfigurationParameterDescriptor:
1444+
type: object
1445+
properties:
1446+
dataType:
1447+
type: string
1448+
description: The data type hint of the configuration parameter
1449+
keyName:
1450+
type: string
1451+
description: The unique key name of the configuration parameter
1452+
required:
1453+
type: boolean
1454+
description: A flag indicating whether the configuration parameter is required
1455+
or not
1456+
description:
1457+
type: string
1458+
description: Describes the configuration parameter
1459+
description: A list of configuration parameter descriptors to be passed when
1460+
creating or updating a configuration instance of this type.
14451461
ConfigurationSourceType:
14461462
type: object
14471463
properties:
1448-
queryParameterKeys:
1464+
parameterDescriptors:
14491465
type: array
1450-
description: A list of query parameter keys to be passed when creating configuration
1451-
instance of this type. Use 'path' key for file URIs
1466+
description: A list of configuration parameter descriptors to be passed
1467+
when creating or updating a configuration instance of this type.
14521468
items:
1453-
type: string
1454-
description: A list of query parameter keys to be passed when creating
1455-
configuration instance of this type. Use 'path' key for file URIs
1469+
$ref: '#/components/schemas/ConfigurationParameterDescriptor'
14561470
description:
14571471
type: string
14581472
description: Describes the configuration source type

0 commit comments

Comments
 (0)