From a037672befe394ad66420e58dbe3f98603f791df Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 01:07:31 +0700 Subject: [PATCH 1/9] fix(player): suspend queue schedule clock when guide is inactive --- components/player/Queue.vue | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/components/player/Queue.vue b/components/player/Queue.vue index 5333f7692..aeffd4086 100644 --- a/components/player/Queue.vue +++ b/components/player/Queue.vue @@ -492,19 +492,29 @@ watch( ); let scheduleClockTimer: ReturnType | null = null; +const needsScheduleClock = computed(() => + activeTab.value === 'schedule' && props.visible && props.scheduleIsReference && props.program.length > 0, +); +const stopScheduleClock = () => { + if (scheduleClockTimer === null) return; + clearInterval(scheduleClockTimer); + scheduleClockTimer = null; +}; onMounted(() => { scheduleNow.value = Math.floor(Date.now() / 1000); - scheduleClockTimer = setInterval(() => { - // Clock and the timeline fill move once per second. Only update the - // visible reference guide; real-time provider EPG is unaffected. - if (activeTab.value === 'schedule' && props.visible && props.scheduleIsReference) { + watch(needsScheduleClock, (active) => { + stopScheduleClock(); + if (!active) return; + scheduleNow.value = Math.floor(Date.now() / 1000); + scheduleClockTimer = setInterval(() => { + // Do not wake the queue when hidden, showing stations or without a guide. scheduleNow.value = Math.floor(Date.now() / 1000); - } - }, 1_000); + }, 1_000); + }, { immediate: true }); if (activeTab.value === 'schedule' && props.visible) void jumpToSchedulePosition(); }); onBeforeUnmount(() => { - if (scheduleClockTimer !== null) clearInterval(scheduleClockTimer); + stopScheduleClock(); scrollGeneration += 1; }); From 179d63151afe9c4ebcc1f651d6c8daf4e1c00ad3 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 01:07:43 +0700 Subject: [PATCH 2/9] test(player): guard reference guide clock idle lifecycle --- tests/station-schedule.test.mjs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tests/station-schedule.test.mjs b/tests/station-schedule.test.mjs index 145cfa662..9471b8bc6 100644 --- a/tests/station-schedule.test.mjs +++ b/tests/station-schedule.test.mjs @@ -157,9 +157,14 @@ test('live time bar is wired to a one-second clock only for visible reference gu const q = await readFile(new URL('../components/player/Queue.vue', import.meta.url), 'utf8'); const gap = await readFile(new URL('../components/player/ScheduleGap.vue', import.meta.url), 'utf8'); assert.match(q, /scheduleTimelineProgress\(item\.startTime, item\.endTime, scheduleNow\.value\)/); + assert.match(q, /watch\(needsScheduleClock, \(active\) => \{/); assert.match(q, /scheduleClockTimer = setInterval\(/); assert.match(q, /\}, 1_000\)/); - assert.match(q, /props\.visible && props\.scheduleIsReference/); + assert.match(q, /activeTab\.value === 'schedule' && props\.visible && props\.scheduleIsReference && props\.program\.length > 0/); + assert.match(q, /if \(!active\) return/); + assert.match(q, /stopScheduleClock\(\)/); + assert.match(q, /onBeforeUnmount\(\(\) => \{\s*stopScheduleClock\(\)/); + assert.doesNotMatch(q, /scheduleClockTimer = setInterval\([\s\S]*?if \(activeTab\.value === 'schedule'/); assert.match(q, /data-schedule-clock role="timer"/); assert.match(q, /data-schedule-time-progress/); assert.match(q, /:start-time="gapStartTime\(scheduleGap\.insertIndex\)"/); From 70ef1f0e8ff5c298449445c43847e20c259f9be4 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 01:07:55 +0700 Subject: [PATCH 3/9] test(player): scope idle clock regression assertion --- tests/station-schedule.test.mjs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/station-schedule.test.mjs b/tests/station-schedule.test.mjs index 9471b8bc6..7479db1e5 100644 --- a/tests/station-schedule.test.mjs +++ b/tests/station-schedule.test.mjs @@ -164,7 +164,7 @@ test('live time bar is wired to a one-second clock only for visible reference gu assert.match(q, /if \(!active\) return/); assert.match(q, /stopScheduleClock\(\)/); assert.match(q, /onBeforeUnmount\(\(\) => \{\s*stopScheduleClock\(\)/); - assert.doesNotMatch(q, /scheduleClockTimer = setInterval\([\s\S]*?if \(activeTab\.value === 'schedule'/); + assert.doesNotMatch(q, /scheduleClockTimer = setInterval\(\(\) => \{[\s\S]*?if \(activeTab\.value === 'schedule' && props\.visible/); assert.match(q, /data-schedule-clock role="timer"/); assert.match(q, /data-schedule-time-progress/); assert.match(q, /:start-time="gapStartTime\(scheduleGap\.insertIndex\)"/); From 649db285ac7e0b696d520ba920a4cf81f458d604 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 01:08:37 +0700 Subject: [PATCH 4/9] test(player): inspect only interval callback for idle guard --- tests/station-schedule.test.mjs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/station-schedule.test.mjs b/tests/station-schedule.test.mjs index 7479db1e5..b770b2633 100644 --- a/tests/station-schedule.test.mjs +++ b/tests/station-schedule.test.mjs @@ -164,7 +164,9 @@ test('live time bar is wired to a one-second clock only for visible reference gu assert.match(q, /if \(!active\) return/); assert.match(q, /stopScheduleClock\(\)/); assert.match(q, /onBeforeUnmount\(\(\) => \{\s*stopScheduleClock\(\)/); - assert.doesNotMatch(q, /scheduleClockTimer = setInterval\(\(\) => \{[\s\S]*?if \(activeTab\.value === 'schedule' && props\.visible/); + const intervalBody = q.match(/scheduleClockTimer = setInterval\(\(\) => \{([\s\S]*?)\}, 1_000\)/)?.[1]; + assert.ok(intervalBody, 'one-second callback exists only behind the eligibility watcher'); + assert.doesNotMatch(intervalBody, /if \(activeTab\.value === 'schedule'/); assert.match(q, /data-schedule-clock role="timer"/); assert.match(q, /data-schedule-time-progress/); assert.match(q, /:start-time="gapStartTime\(scheduleGap\.insertIndex\)"/); From 68c79b2a565b4c6173b173e197257c2c3fce68e7 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 04:07:51 +0700 Subject: [PATCH 5/9] fix(player): tolerate unavailable browser storage --- utils/player-storage.mjs | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 utils/player-storage.mjs diff --git a/utils/player-storage.mjs b/utils/player-storage.mjs new file mode 100644 index 000000000..48ffa9b6b --- /dev/null +++ b/utils/player-storage.mjs @@ -0,0 +1,9 @@ +// Storage can throw in private browsing, sandboxed frames or restricted browsers. +// Player controls must remain usable even when persistence is unavailable. +export function readPlayerStorage(key, getStorage = () => globalThis.localStorage) { + try { return getStorage().getItem(key); } catch { return null; } +} + +export function writePlayerStorage(key, value, getStorage = () => globalThis.localStorage) { + try { getStorage().setItem(key, value); return true; } catch { return false; } +} From d38b181ed5f8abdff5b86b183275fd416e1d5b12 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 04:08:00 +0700 Subject: [PATCH 6/9] fix(player): keep player controls working when localStorage throws --- components/player/Player.vue | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/components/player/Player.vue b/components/player/Player.vue index 6e3a856c7..bd464058c 100644 --- a/components/player/Player.vue +++ b/components/player/Player.vue @@ -205,6 +205,7 @@ import { isCurrentMediaPlaying, playbackWatchdogAction, nextRecoverySourceIndex, import { stationReportUrl, stationReportEmailUrl } from "~/utils/station-sharing.mjs"; import { resolvePlaylistSource } from "~/utils/radio-playlist.mjs"; import { resolveLiveTrack } from "~/utils/live-track.mjs"; +import { readPlayerStorage, writePlayerStorage } from "~/utils/player-storage.mjs"; import { createTimedHlsTrackBuffer, extractNativeHlsId3Track } from "~/utils/hls-song-metadata.mjs"; interface CurrentMedia { @@ -297,7 +298,7 @@ const finishPlayerAction = () => { const action = pendingPlayerAction; pendingPl const wideViewport = ref(false); const updateViewport = () => { wideViewport.value = window.innerWidth >= 1536; if (wideViewport.value) mobileQueueOpen.value = false; }; const persistQueueOpen = (): void => { - if (import.meta.client) localStorage.setItem(PLAYER_QUEUE_OPEN_KEY, playback.queueOpen ? '1' : '0'); + if (import.meta.client) writePlayerStorage(PLAYER_QUEUE_OPEN_KEY, playback.queueOpen ? '1' : '0'); }; const setQueueOpen = (value: boolean): void => { playback.queueOpen = value; @@ -399,7 +400,7 @@ const playerMini = toRef(playback, 'playerMini'); const playerStatusVisible = computed(() => streamError.value || !online.value || waiting.value || resolvingGlobalSelection.value || !hasPlayableSource.value || Boolean(sleepRemaining.value)); const togglePlayerCompact = (): void => { playerCompact.value = !playerCompact.value; - if (import.meta.client) localStorage.setItem('radio:player-compact', playerCompact.value ? '1' : '0'); + if (import.meta.client) writePlayerStorage('radio:player-compact', playerCompact.value ? '1' : '0'); }; const setPlayerMini = (value: boolean): void => { playerMini.value = value; @@ -407,7 +408,7 @@ const setPlayerMini = (value: boolean): void => { setQueueOpen(false); mobileQueueOpen.value = false; } - if (import.meta.client) localStorage.setItem('radio:player-mini', value ? '1' : '0'); + if (import.meta.client) writePlayerStorage('radio:player-mini', value ? '1' : '0'); }; let hlsInstance: any = null; @@ -1362,7 +1363,7 @@ const onVolumeChange = (): void => { muted.value = media.muted; if (preferences.rememberVolume) { try { - localStorage.setItem(AUDIO_PREFERENCES_KEY, JSON.stringify({ volume: media.volume, muted: media.muted })); + writePlayerStorage(AUDIO_PREFERENCES_KEY, JSON.stringify({ volume: media.volume, muted: media.muted })); } catch { /* Storage restrictions must not interrupt audio. */ } } }; @@ -1507,9 +1508,9 @@ onMounted(() => { window.addEventListener('radio:listening-duration-reset', resetListeningTracking); document.addEventListener("visibilitychange", checkSleepDeadline); window.addEventListener("pageshow", checkSleepDeadline); - playerCompact.value = localStorage.getItem('radio:player-compact') === '1'; - playerMini.value = localStorage.getItem('radio:player-mini') === '1'; - playback.queueOpen = localStorage.getItem(PLAYER_QUEUE_OPEN_KEY) === '1' && !playerMini.value; + playerCompact.value = readPlayerStorage('radio:player-compact') === '1'; + playerMini.value = readPlayerStorage('radio:player-mini') === '1'; + playback.queueOpen = readPlayerStorage(PLAYER_QUEUE_OPEN_KEY) === '1' && !playerMini.value; systemVolumeOnly.value = usesSystemVolumeControls(navigator); const [, area, country] = props.country.split("."); if (area && country) { @@ -1524,7 +1525,7 @@ onMounted(() => { const savedMedia = mediaElement.value; if (savedMedia && preferences.rememberVolume) { try { - const saved = JSON.parse(localStorage.getItem(AUDIO_PREFERENCES_KEY) || 'null'); + const saved = JSON.parse(readPlayerStorage(AUDIO_PREFERENCES_KEY) || 'null'); if (saved && typeof saved.muted === 'boolean') savedMedia.muted = saved.muted; if (!systemVolumeOnly.value && typeof saved?.volume === 'number' && Number.isFinite(saved.volume) && saved.volume >= 0 && saved.volume <= 1) { From 55d7af71405734382692b7eace2b9fd14f55a556 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 04:08:07 +0700 Subject: [PATCH 7/9] test(player): cover denied and quota-limited storage --- tests/player-storage.test.mjs | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) create mode 100644 tests/player-storage.test.mjs diff --git a/tests/player-storage.test.mjs b/tests/player-storage.test.mjs new file mode 100644 index 000000000..58f11af30 --- /dev/null +++ b/tests/player-storage.test.mjs @@ -0,0 +1,31 @@ +import test from 'node:test'; +import assert from 'node:assert/strict'; +import { readPlayerStorage, writePlayerStorage } from '../utils/player-storage.mjs'; + +test('player storage round-trips persisted UI and volume values', () => { + const values = new Map(); + const storage = () => ({ + getItem: key => values.get(key) ?? null, + setItem: (key, value) => { values.set(key, value); }, + }); + assert.equal(readPlayerStorage('radio:player-mini', storage), null); + assert.equal(writePlayerStorage('radio:player-mini', '1', storage), true); + assert.equal(readPlayerStorage('radio:player-mini', storage), '1'); + assert.equal(writePlayerStorage('radio:audio-preferences:v1', '{"volume":0.5}', storage), true); + assert.equal(readPlayerStorage('radio:audio-preferences:v1', storage), '{"volume":0.5}'); +}); + +test('player remains functional when storage access is blocked', () => { + const denied = () => { throw new DOMException('Access denied', 'SecurityError'); }; + assert.equal(readPlayerStorage('radio:player-mini', denied), null); + assert.equal(writePlayerStorage('radio:player-mini', '1', denied), false); +}); + +test('player tolerates getItem and setItem failures independently', () => { + const storage = () => ({ + getItem: () => { throw new Error('get failed'); }, + setItem: () => { throw new Error('quota exceeded'); }, + }); + assert.equal(readPlayerStorage('radio:player-compact', storage), null); + assert.equal(writePlayerStorage('radio:player-compact', '1', storage), false); +}); From 662ce3b0008fbe938eb9f3d346fe51fce461b3ca Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 14:13:04 +0700 Subject: [PATCH 8/9] fix(schedule): reject malformed and credential-bearing EPG URLs --- utils/station-schedule.mjs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/utils/station-schedule.mjs b/utils/station-schedule.mjs index afb163a21..e76e9252e 100644 --- a/utils/station-schedule.mjs +++ b/utils/station-schedule.mjs @@ -4,7 +4,14 @@ export const normalizeScheduleUrl = (value) => { const url = value.trim(); if (!/^https?:\/\//i.test(url)) return ""; - return url; + try { + const parsed = new URL(url); + // Reject malformed endpoints and embedded credentials before a schedule fetch. + if (!["http:", "https:"].includes(parsed.protocol) || !parsed.hostname || parsed.username || parsed.password) return ""; + return url; + } catch { + return ""; + } }; export const isZingScheduleUrl = (value) => { From 5bebaa5af217b622257e9a0516838d3a9a29f929 Mon Sep 17 00:00:00 2001 From: David Nguyen Date: Tue, 17 Nov 2026 14:13:06 +0700 Subject: [PATCH 9/9] test(schedule): cover malformed and credential-bearing URLs --- tests/station-schedule.test.mjs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/station-schedule.test.mjs b/tests/station-schedule.test.mjs index b770b2633..826430e6a 100644 --- a/tests/station-schedule.test.mjs +++ b/tests/station-schedule.test.mjs @@ -20,6 +20,10 @@ test("normalizes only real HTTP schedule URLs", () => { assert.equal(normalizeScheduleUrl(false), ""); assert.equal(normalizeScheduleUrl(""), ""); assert.equal(normalizeScheduleUrl("schedule-only"), ""); + assert.equal(normalizeScheduleUrl("https://"), ""); + assert.equal(normalizeScheduleUrl("https://example.com:bad/epg"), ""); + assert.equal(normalizeScheduleUrl("https://user:pass@example.com/epg"), ""); + assert.equal(normalizeScheduleUrl("https://example.com/epg"), "https://example.com/epg"); }); test("detects Zing schedule by provider endpoint instead of country", () => {