[feature request] Support bun

[miniBill]

If you run the CLI in a folder with a bun lockfile it errors out due to the lack of (recognized) lock file

[43081j]

i think this would need us to add support for bun.lock to the lockparse library.

could you open an equivalent issue there if there isn't one yet?

we can keep this open too until this CLI pulls it in

[gameroman]

Pretty sure it already does

https://github.com/43081j/lockparse/blob/main/src/parsers/bun.ts

[43081j]

so it does! and i wrote it 😂

so maybe this is a cli bug after all. @dreyfus92 any chance you can take a look?

[dreyfus92]

this shouldn't be a cli's error since it relies on lockparse for parsing lock files so, i can take a look and see what's going on 😄

[dreyfus92]

so after doing some research, apparently the cli detection is incomplete for bun's lockfile naming bun.lockb/ buns.lockfile aren't recognized. also lockparse currently only parses bun.lock with these two you can explain why @miniBill is seeing "lack of recognized lock file" rather than a parsing error.

i don't know much about bun, but are we aiming to parse other variants of lockfiles? or what would be the end goal for support for bun @43081j?

[gameroman]

This is first time I am hearing about buns.lockfile, and bun.lockb is a legacy format so I don't think we should be supporting it

[gameroman]

I don't think buns.lockfile is a real thing

[dreyfus92]

i'm gonna create a fixture to make sure the cli detects and parses buns.lock

[gameroman]

Do you mean bun.lock? buns.lock is not a real thing

[dreyfus92]

i meant bun.lock, sorry for the typo there 😄

[dreyfus92]

@miniBill i've created a fixture and a simple test and it is working as expected, do you have a repo you can share so i can investigate a bit further?

[itpropro]

Have the same problem on all projects using bun:

❯ bunx @e18e/cli analyze
e18e (cli v0.5.0)

┌  Analyzing...
file:///tmp/bunx-1001-@e18e/cli@latest/node_modules/@e18e/cli/lib/analyze/report.js:35
        throw new Error('No lockfile found in the project root.');
              ^

PS: Same issue when running with pnpx

[dreyfus92]

I've tested both package managers and i'm not facing issues, this is a weird behavior @itpropro would you mind sharing your repo? also i wonder what OS are you working with?

[dreyfus92]

i'm here thinking if those runners often unpack or install the package under something like /tmp/bunx.... and if that's the case the spawned node procces's cwd ends up being that tooling directory or anything that isn't the repo you car about, the cli will look there, find no plock and throw before lockparse runs 🤔

[gameroman]

I used bunx @e18e/cli analyze in my bun project and it worked fine