Address PR comments

Author: CrisBarreiro

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

@@ -3211,7 +3211,7 @@ class BrowserTabFragment :
             it.clearSslPreferences()
 
             it.settings.apply {
-                withContext(dispatchers.io()) { clientBrandHintProvider.setDefault(this@apply) }
+                clientBrandHintProvider.setDefault(this)
                 webViewClient.clientProvider = clientBrandHintProvider
                 userAgentString = userAgentProvider.userAgent()
                 javaScriptEnabled = true
@@ -3514,7 +3514,7 @@ class BrowserTabFragment :
             webViewCapabilityChecker.isSupported(WebViewCapability.WebMessageListener) &&
             webViewCapabilityChecker.isSupported(WebViewCapability.DocumentStartJavaScript)
 
-    private suspend fun configureWebViewForAutofill(it: DuckDuckGoWebView) {
+    private fun configureWebViewForAutofill(it: DuckDuckGoWebView) {
         it.setSystemAutofillCallback {
             systemAutofillEngagement.onSystemAutofillEvent()
         }

user-agent/user-agent-api/src/main/java/com/duckduckgo/user/agent/api/ClientBrandHintProvider.kt

@@ -31,7 +31,7 @@ interface ClientBrandHintProvider {
      * Sets the default client hint header SEC-CH-UA
      * @param settings [WebSettings] where the agent metadata will be set
      */
-    fun setDefault(settings: WebSettings)
+    suspend fun setDefault(settings: WebSettings)
 
     /**
      * Checks if the url passed as parameter will force a change of branding

user-agent/user-agent-impl/src/main/java/com/duckduckgo/user/agent/impl/ClientBrandHintProvider.kt

@@ -23,6 +23,7 @@ import androidx.webkit.UserAgentMetadata
 import androidx.webkit.UserAgentMetadata.BrandVersion
 import androidx.webkit.WebSettingsCompat
 import androidx.webkit.WebViewFeature
+import com.duckduckgo.common.utils.DispatcherProvider
 import com.duckduckgo.di.scopes.AppScope
 import com.duckduckgo.user.agent.api.ClientBrandHintProvider
 import com.duckduckgo.user.agent.impl.remoteconfig.BrandingChange
@@ -35,6 +36,7 @@ import com.duckduckgo.user.agent.impl.remoteconfig.ClientBrandsHints.CHROME
 import com.duckduckgo.user.agent.impl.remoteconfig.ClientBrandsHints.DDG
 import com.duckduckgo.user.agent.impl.remoteconfig.ClientBrandsHints.WEBVIEW
 import com.squareup.anvil.annotations.ContributesBinding
+import kotlinx.coroutines.withContext
 import logcat.LogPriority.INFO
 import logcat.LogPriority.VERBOSE
 import logcat.logcat
@@ -44,13 +46,14 @@ import javax.inject.Inject
 class RealClientBrandHintProvider @Inject constructor(
     private val clientBrandHintFeature: ClientBrandHintFeature,
     private val repository: ClientBrandHintFeatureSettingsRepository,
+    private val dispatcherProvider: DispatcherProvider,
 ) : ClientBrandHintProvider {
 
     private var currentDomain: String? = null
     private var currentBranding: ClientBrandsHints = DDG
 
-    override fun setDefault(settings: WebSettings) {
-        if (clientBrandHintFeature.self().isEnabled()) {
+    override suspend fun setDefault(settings: WebSettings) {
+        if (withContext(dispatcherProvider.io()) { clientBrandHintFeature.self().isEnabled() }) {
             logcat(VERBOSE) { "ClientBrandHintProvider: branding enabled, initialising metadata with DuckDuckGo branding" }
             setUserAgentMetadata(settings, DEFAULT_ENABLED_BRANDING)
         } else {