Review comments (#2)

* #1 Replace anonymous function
* Add description and fix phpcs

Author: fnpen

README.md

@@ -26,6 +26,12 @@ Use local settings:
 -   Account Key: `Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==`
 -   Blob Service Endpoint: `http://127.0.0.1:10000/devstoreaccount1`
 
+## Vendor Scoping
+
+We use php-scoper to add prefixes to all vendor files, to avoid risks of fatal errors if you activate two plugins that use the same packages.
+
+You need to run the command: `composer scoper` to upgrade the vendor-prefixed folder when the vendor folder is updated.
+
 ## Credits
 
 Developed by [Dekode](https://en.dekode.no/?noredirect=en_US) for [DSS](https://www.dss.dep.no/about-us/).

gravityforms-uploads-azure.php

@@ -22,7 +22,12 @@
 	require_once __DIR__ . '/vendor-prefixed/autoload.php';
 }
 
-add_action( 'gform_loaded', function() {
+/**
+ * Bootstrap plugin, load it using gform_loaded hook.
+ *
+ * @return void
+ */
+function gform_loaded() {
 	// Check that te GravityForms File Upload plugin is loaded before we try extending it.
 	if ( ! method_exists( 'GFForms', 'include_feed_addon_framework' ) ) {
 		return;
@@ -38,4 +43,6 @@
 	add_filter( 'gform_secure_file_download_is_https', '__return_false', 200 );
 
 	\GFAddOn::register( __NAMESPACE__ . '\\AddOn' );
-}, 10 );
+}
+
+add_action( 'gform_loaded', __NAMESPACE__ . '\\gform_loaded', 10 );

phpcs.xml.dist

@@ -4,6 +4,9 @@
 	<arg name="extensions" value="php" />
 	<config name="testVersion" value="7.2-" />
 
+	<exclude-pattern>vendor-prefixed</exclude-pattern>
+	<exclude-pattern>php-scoper</exclude-pattern>
+
 	<rule ref="Dekode">
 		<exclude name="Generic.Arrays.DisallowShortArraySyntax" />
 		<exclude name="WordPress.PHP.DisallowShortTernary.Found" />