feat(refactor): agent

remove duplicated model properties from AgentConfig

Author: bhouston

packages/agent/src/core/toolAgent/config.ts

@@ -15,10 +15,6 @@ export type ModelProvider = 'anthropic' | 'openai' | 'ollama';
 
 export type AgentConfig = {
   maxIterations: number;
-  provider: ModelProvider;
-  model: string;
-  maxTokens: number;
-  temperature: number;
   getSystemPrompt: (toolContext: ToolContext) => string;
 };
 
@@ -55,10 +51,6 @@ export function getModel(
  */
 export const DEFAULT_CONFIG: AgentConfig = {
   maxIterations: 200,
-  provider: 'anthropic',
-  model: 'claude-3-7-sonnet-20250219',
-  maxTokens: 4096,
-  temperature: 0.7,
   getSystemPrompt: getDefaultSystemPrompt,
 };
 

packages/agent/src/core/toolAgent/toolAgentCore.ts

@@ -43,7 +43,7 @@ export const toolAgent = async (
   const systemPrompt = config.getSystemPrompt(context);
 
   // Create the LLM provider
-  const provider = createProvider(config.provider, config.model);
+  const provider = createProvider(context.provider, context.model);
 
   for (let i = 0; i < config.maxIterations; i++) {
     logger.verbose(
@@ -74,8 +74,8 @@ export const toolAgent = async (
     const generateOptions = {
       messages: messagesWithSystem,
       functions: functionDefinitions,
-      temperature: config.temperature,
-      maxTokens: config.maxTokens,
+      temperature: context.temperature,
+      maxTokens: context.maxTokens,
     };
 
     const { text, toolCalls, tokenUsage } = await generateText(

packages/agent/src/core/types.ts

@@ -24,6 +24,8 @@ export type ToolContext = {
   agentId?: string; // Unique identifier for the agent, used for background tool tracking
   provider: ModelProvider;
   model: string;
+  maxTokens: number;
+  temperature: number;
 };
 
 export type Tool<TParams = Record<string, any>, TReturn = any> = {

packages/agent/src/tools/getTools.test.ts

@@ -17,6 +17,8 @@ export const getMockToolContext = (): ToolContext => ({
   githubMode: true,
   provider: 'anthropic',
   model: 'claude-3-7-sonnet-20250219',
+  maxTokens: 4096,
+  temperature: 0.7,
 });
 
 describe('getTools', () => {

packages/agent/src/tools/interaction/agentStart.ts

@@ -69,10 +69,6 @@ type ReturnType = z.infer<typeof returnSchema>;
 // Sub-agent specific configuration
 const subAgentConfig: AgentConfig = {
   maxIterations: 200,
-  maxTokens: 4096,
-  temperature: 0.7,
-  provider: 'anthropic',
-  model: 'claude-3-7-sonnet-20250219',
   getSystemPrompt: (context: ToolContext) => {
     return [
       getDefaultSystemPrompt(context),

packages/agent/src/tools/interaction/agentTools.test.ts

@@ -26,6 +26,8 @@ const mockContext: ToolContext = {
   githubMode: true,
   provider: 'anthropic',
   model: 'claude-3-7-sonnet-20250219',
+  maxTokens: 4096,
+  temperature: 0.7,
 };
 
 describe('Agent Tools', () => {

packages/agent/src/tools/interaction/subAgent.test.ts

@@ -30,6 +30,8 @@ const mockContext: ToolContext = {
   githubMode: true,
   provider: 'anthropic',
   model: 'claude-3-7-sonnet-20250219',
+  maxTokens: 4096,
+  temperature: 0.7,
 };
 
 describe('subAgentTool', () => {

packages/agent/src/tools/interaction/subAgent.ts

@@ -47,10 +47,6 @@ type ReturnType = z.infer<typeof returnSchema>;
 // Sub-agent specific configuration
 const subAgentConfig: AgentConfig = {
   maxIterations: 200,
-  provider: 'anthropic',
-  model: 'claude-3-7-sonnet-20250219',
-  maxTokens: 4096,
-  temperature: 0.7,
   getSystemPrompt: (context: ToolContext) => {
     return [
       getDefaultSystemPrompt(context),
@@ -106,11 +102,9 @@ export const subAgentTool: Tool<Parameters, ReturnType> = {
 
     const tools = getTools({ userPrompt: false });
 
-    // Update config if timeout is specified
+    // Use the subAgentConfig
     const config: AgentConfig = {
       ...subAgentConfig,
-      provider: context.provider,
-      model: context.model,
     };
 
     try {

packages/cli/src/commands/$default.ts

@@ -146,13 +146,9 @@ export const command: CommandModule<SharedOptions, DefaultArgs> = {
         process.exit(0);
       });
 
-      // Create a config with the selected model
+      // Create a config for the agent
       const agentConfig: AgentConfig = {
         ...DEFAULT_CONFIG,
-        provider: config.provider as ModelProvider,
-        model: config.model,
-        maxTokens: config.maxTokens,
-        temperature: config.temperature,
       };
 
       const result = await toolAgent(prompt, tools, agentConfig, {
@@ -168,6 +164,8 @@ export const command: CommandModule<SharedOptions, DefaultArgs> = {
         userPrompt: config.userPrompt,
         provider: config.provider as ModelProvider,
         model: config.model,
+        maxTokens: config.maxTokens,
+        temperature: config.temperature,
       });
 
       const output =