Fix for GetXmlNamespaceMaps and SetXmlNamespaceMaps exception (#8510)

Anjali · web-flow · commit d66b9b81d86b · 2024-02-02T11:49:46.000+05:30
* Addressed invalid cast Exception

* Changed datatype for SetXmlNamespaceMaps

* Fix for API Compat error
diff --git a/src/Microsoft.DotNet.Wpf/ApiCompat/Baselines/PresentationFramework-ref-Net48.baseline.txt b/src/Microsoft.DotNet.Wpf/ApiCompat/Baselines/PresentationFramework-ref-Net48.baseline.txt
@@ -33,4 +33,6 @@ TypesMustExist : Type 'System.Windows.Interop.DocObjHost' does not exist in the
 CannotRemoveAttribute : Attribute 'System.ComponentModel.TypeConverterAttribute' exists on 'System.Windows.Markup.StaticExtension' in the contract but not the implementation.
 CannotRemoveAttribute : Attribute 'System.ComponentModel.TypeConverterAttribute' exists on 'System.Windows.Markup.TypeExtension' in the contract but not the implementation.
 CannotRemoveBaseTypeOrInterface : Type 'System.Windows.Markup.XamlParseException' does not implement interface 'System.Runtime.InteropServices._Exception' in the implementation but it does in the contract.
-Total Issues: 34
+MembersMustExist : Member 'public System.String System.Windows.Markup.XmlAttributeProperties.GetXmlNamespaceMaps(System.Windows.DependencyObject)' does not exist in the implementation but it does exist in the contract.
+MembersMustExist : Member 'public void System.Windows.Markup.XmlAttributeProperties.SetXmlNamespaceMaps(System.Windows.DependencyObject, System.String)' does not exist in the implementation but it does exist in the contract.
+Total Issues: 36
diff --git a/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs b/src/Microsoft.DotNet.Wpf/cycle-breakers/PresentationFramework/PresentationFramework.cs
@@ -11485,7 +11485,7 @@ internal XmlAttributeProperties() { }
         public static readonly System.Windows.DependencyProperty XmlSpaceProperty;
         [System.ComponentModel.DesignerSerializationVisibilityAttribute(System.ComponentModel.DesignerSerializationVisibility.Hidden)]
         [System.Windows.AttachedPropertyBrowsableForTypeAttribute(typeof(System.Windows.DependencyObject))]
-        public static string GetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject) { throw null; }
+        public static System.Collections.Hashtable GetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject) { throw null; }
         [System.ComponentModel.DesignerSerializationVisibilityAttribute(System.ComponentModel.DesignerSerializationVisibility.Hidden)]
         [System.Windows.AttachedPropertyBrowsableForTypeAttribute(typeof(System.Windows.DependencyObject))]
         [System.Windows.Markup.DesignerSerializationOptionsAttribute(System.Windows.Markup.DesignerSerializationOptions.SerializeAsAttribute)]
@@ -11496,7 +11496,7 @@ internal XmlAttributeProperties() { }
         [System.Windows.AttachedPropertyBrowsableForTypeAttribute(typeof(System.Windows.DependencyObject))]
         [System.Windows.Markup.DesignerSerializationOptionsAttribute(System.Windows.Markup.DesignerSerializationOptions.SerializeAsAttribute)]
         public static string GetXmlSpace(System.Windows.DependencyObject dependencyObject) { throw null; }
-        public static void SetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject, string value) { }
+        public static void SetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject, System.Collections.Hashtable value) { }
         public static void SetXmlnsDefinition(System.Windows.DependencyObject dependencyObject, string value) { }
         public static void SetXmlnsDictionary(System.Windows.DependencyObject dependencyObject, System.Windows.Markup.XmlnsDictionary value) { }
         public static void SetXmlSpace(System.Windows.DependencyObject dependencyObject, string value) { }
diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/XmlAttributeProperties.cs b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/Markup/XmlAttributeProperties.cs
@@ -296,14 +296,14 @@ public static void SetXmlnsDefinition(DependencyObject dependencyObject, string
         /// </remarks>
         [DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
         [AttachedPropertyBrowsableForType(typeof(DependencyObject))]
-        public static string GetXmlNamespaceMaps(DependencyObject dependencyObject)
+        public static Hashtable GetXmlNamespaceMaps(DependencyObject dependencyObject)
         {
             if (dependencyObject == null)
             {
                 throw new ArgumentNullException( "dependencyObject" );
             }
 
-            return (string)dependencyObject.GetValue(XmlNamespaceMapsProperty);
+            return (Hashtable)dependencyObject.GetValue(XmlNamespaceMapsProperty);
         }
 
         /// <summary>
@@ -312,7 +312,7 @@ public static string GetXmlNamespaceMaps(DependencyObject dependencyObject)
         /// <remarks>
         /// XmlNamespaceMaps map xml namespace uri to Assembly/CLR namespaces
         /// </remarks>
-        public static void SetXmlNamespaceMaps(DependencyObject dependencyObject, string value)
+        public static void SetXmlNamespaceMaps(DependencyObject dependencyObject, Hashtable value)
         {
             if (dependencyObject == null)
             {
diff --git a/src/Microsoft.DotNet.Wpf/src/PresentationFramework/ref/PresentationFramework.cs b/src/Microsoft.DotNet.Wpf/src/PresentationFramework/ref/PresentationFramework.cs
@@ -11505,7 +11505,7 @@ internal XmlAttributeProperties() { }
         public static readonly System.Windows.DependencyProperty XmlSpaceProperty;
         [System.ComponentModel.DesignerSerializationVisibilityAttribute(System.ComponentModel.DesignerSerializationVisibility.Hidden)]
         [System.Windows.AttachedPropertyBrowsableForTypeAttribute(typeof(System.Windows.DependencyObject))]
-        public static string GetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject) { throw null; }
+        public static System.Collections.Hashtable GetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject) { throw null; }
         [System.ComponentModel.DesignerSerializationVisibilityAttribute(System.ComponentModel.DesignerSerializationVisibility.Hidden)]
         [System.Windows.AttachedPropertyBrowsableForTypeAttribute(typeof(System.Windows.DependencyObject))]
         [System.Windows.Markup.DesignerSerializationOptionsAttribute(System.Windows.Markup.DesignerSerializationOptions.SerializeAsAttribute)]
@@ -11516,7 +11516,7 @@ internal XmlAttributeProperties() { }
         [System.Windows.AttachedPropertyBrowsableForTypeAttribute(typeof(System.Windows.DependencyObject))]
         [System.Windows.Markup.DesignerSerializationOptionsAttribute(System.Windows.Markup.DesignerSerializationOptions.SerializeAsAttribute)]
         public static string GetXmlSpace(System.Windows.DependencyObject dependencyObject) { throw null; }
-        public static void SetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject, string value) { }
+        public static void SetXmlNamespaceMaps(System.Windows.DependencyObject dependencyObject, System.Collections.Hashtable value) { }
         public static void SetXmlnsDefinition(System.Windows.DependencyObject dependencyObject, string value) { }
         public static void SetXmlnsDictionary(System.Windows.DependencyObject dependencyObject, System.Windows.Markup.XmlnsDictionary value) { }
         public static void SetXmlSpace(System.Windows.DependencyObject dependencyObject, string value) { }

Original file line number	Diff line number	Diff line change
`@@ -296,14 +296,14 @@ public static void SetXmlnsDefinition(DependencyObject dependencyObject, string`
`296`	`296`	`/// </remarks>`
`297`	`297`	`[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]`
`298`	`298`	`[AttachedPropertyBrowsableForType(typeof(DependencyObject))]`
`299`		`- public static string GetXmlNamespaceMaps(DependencyObject dependencyObject)`
	`299`	`+ public static Hashtable GetXmlNamespaceMaps(DependencyObject dependencyObject)`
`300`	`300`	`{`
`301`	`301`	`if (dependencyObject == null)`
`302`	`302`	`{`
`303`	`303`	`throw new ArgumentNullException( "dependencyObject" );`
`304`	`304`	`}`
`305`	`305`
`306`		`- return (string)dependencyObject.GetValue(XmlNamespaceMapsProperty);`
	`306`	`+ return (Hashtable)dependencyObject.GetValue(XmlNamespaceMapsProperty);`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`/// <summary>`
`@@ -312,7 +312,7 @@ public static string GetXmlNamespaceMaps(DependencyObject dependencyObject)`
`312`	`312`	`/// <remarks>`
`313`	`313`	`/// XmlNamespaceMaps map xml namespace uri to Assembly/CLR namespaces`
`314`	`314`	`/// </remarks>`
`315`		`- public static void SetXmlNamespaceMaps(DependencyObject dependencyObject, string value)`
	`315`	`+ public static void SetXmlNamespaceMaps(DependencyObject dependencyObject, Hashtable value)`
`316`	`316`	`{`
`317`	`317`	`if (dependencyObject == null)`
`318`	`318`	`{`