JIT: Tail-merge robust crossJumpVictim selection#129141
Open
BoyBaykiller wants to merge 3 commits into
Open
Conversation
…ases like optimizeBools
* don't early out * make NoGcPoll preference explicit
BoyBaykiller
changed the title
crossJumpVictimcrossJumpVictim
github-actions
Bot
added
the
area-CodeGen-coreclr
BoyBaykiller
changed the title
crossJumpVictimcrossJumpVictim selection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Currently includes #129092 which should be merged first
Previously,
crossJumpVictimselection logic was dependent on the order of candidates which can lead to random diffs.I removed the early out and added a tie-break which makes it order independent and sets the stage for a follow up zero-diff PR that processes all sets at once.
For the tie-break I used:
predBlock->bbNum < crossJumpVictim->bbNum. This actually has few good diffs because it preferences away fromBBF_NEEDS_GCPOLLblocks for some reason. I'd be nice to add that as a seperate heuristic instead of being implicitly encoded in the tie-break.