[ci-scan-feedback] Fix push to existing feedback PR on scheduled runs#129132
Merged
kotlarmilos merged 2 commits intoJun 9, 2026
Merged
Conversation
The feedback workflow runs on a schedule, so there is no triggering pull request. push-to-pull-request-branch and update-pull-request defaulted to target: triggering, which fails with "requires pull request context" and cancels the remaining safe outputs. As a result the agent could never add commits to the existing [ci-scan-feedback] PR and fell back to filing an issue with a patch. Set target: "*" on both so they operate on the PR discovered in Step 6, and constrain push-to-pull-request-branch with title-prefix "[ci-scan-feedback] " so it can only push to the feedback PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the safe-output configuration for the CI Outer-Loop Failure Scanner — Feedback workflow so scheduled runs (which have no “triggering PR”) can still push commits to, and update, the existing [ci-scan-feedback] feedback PR that the agent discovers at runtime.
Changes:
- Configure
push-to-pull-request-branchto target any discovered PR (target: "*") and restrict pushes to PRs with the[ci-scan-feedback]title prefix. - Configure
update-pull-requestto target any discovered PR (target: "*") so scheduled runs can update the discovered feedback PR. - Regenerate
.lock.ymlviagh aw compile, updating the compiled safe-outputs config accordingly.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/ci-failure-scan-feedback.md |
Updates safe-outputs to allow scheduled runs to push/update the discovered feedback PR (no triggering PR required). |
.github/workflows/ci-failure-scan-feedback.lock.yml |
Regenerated compiled workflow; includes updated safe-outputs wiring, but also introduces a detection-job dependency regression that must be fixed. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
vitek-karas
approved these changes
Jun 8, 2026
# Conflicts: # .github/workflows/ci-failure-scan-feedback.lock.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
CI Outer-Loop Failure Scanner — Feedbackworkflow runs on a dailyschedule, so there is no triggering pull request. Itspush-to-pull-request-branchandupdate-pull-requestsafe-outputs defaulted totarget: triggering, which fails at runtime with:Step 6 of the prompt instructs the agent to push new edits onto the existing
[ci-scan-feedback]PR when one is open. That push can never succeed on a scheduled run, so the workflow fails and the agent falls back to filing an issue with a patch instead of updating the PR. Recent failing runs: 27083450473, 26996513228, 26736663476. See also #128972 and #128881.Fix
target: "*"onpush-to-pull-request-branchandupdate-pull-requestso they operate on the PR the agent discovers in Step 6 rather than a (nonexistent) triggering PR. This mirrorsupdate-issue, which already usestarget: "*".push-to-pull-request-branchwithtitle-prefix: "[ci-scan-feedback] "so it can only push to the feedback PR..lock.ymlregenerated withgh aw compile(v0.71.5, matching the committed compiler version).