Skip to content

Pool the dictionary buffer when training a Zstandard dictionary #129125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alinpahontu2912 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −2
Open

Pool the dictionary buffer when training a Zstandard dictionary #129125

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
805ecdc
Pool the dictionary buffer when training a Zstandard dictionary
alinpahontu2912 Jun 8, 2026
6941ad1
address comments
alinpahontu2912 Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...ibraries/System.IO.Compression/src/System/IO/Compression/Zstandard/ZstandardDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ public static ZstandardDictionary Train(ReadOnlySpan<byte> samples, ReadOnlySpan
// This incidentally also protects against concurrent modifications of the sampleLengths that could cause
// access violations later in native code.
byte[] lengthsArray = ArrayPool<byte>.Shared.Rent(sampleLengths.Length * Unsafe.SizeOf<nuint>());
byte[]? dictionaryBuffer = null;
try
{
Span<nuint> lengthsAsNuint = MemoryMarshal.Cast<byte, nuint>(lengthsArray.AsSpan(0, sampleLengths.Length * Unsafe.SizeOf<nuint>()));
Expand All @@ -127,8 +128,7 @@ public static ZstandardDictionary Train(ReadOnlySpan<byte> samples, ReadOnlySpan

ArgumentOutOfRangeException.ThrowIfLessThan(maxDictionarySize, 256, nameof(maxDictionarySize));

byte[] dictionaryBuffer = new byte[maxDictionarySize];

dictionaryBuffer = ArrayPool<byte>.Shared.Rent(maxDictionarySize);
nuint dictSize;

unsafe
Expand All @@ -148,6 +148,10 @@ public static ZstandardDictionary Train(ReadOnlySpan<byte> samples, ReadOnlySpan
}
finally
{
if (dictionaryBuffer is not null)
{
ArrayPool<byte>.Shared.Return(dictionaryBuffer);
}
ArrayPool<byte>.Shared.Return(lengthsArray);
}
}
Expand Down
Loading