A question about contributions & different concerns within them

[asylkhan-azat]

I have a question about how to structure a bugfix PR. I found the likely cause of dotnet/runtime#20269 and have a fix ready.

Concurrent inserts into the transaction table’s timeout list can leave an empty bucket set with no strong reference. Once the GC collects it, the sets behind it drop out of the list and their transactions never time out.

Along the way I did some cleanup to understand the code better. It doesn’t change the logic: typed WeakReference<T> instead of untyped, a couple of fields turned into constants, removing an unused back-reference, and extracting a few methods.

So my question is should I submit only the fixes, or is it fine to include the cleanup in the same PR as separate commits?

[!NOTE]
Claude helped to write the repro. It also found a second bug with transactions not timing out properly when timer marked the set of being timed out.

[huoyaoyuan]

I found the likely cause of dotnet/runtime#20269 and have a fix ready.

The issue is very old and the component (System.Transactions.Local) is inactive. You need to provide enough evidence for the fix.

So my question is should I submit only the fixes, or is it fine to include the cleanup in the same PR as separate commits?

Don't mix unrelated changes with bugfix. Moreover, it's likely never acceptable for these changes due to the library being inactive.

[asylkhan-azat]

Thanks for swift reply

[asylkhan-azat]

May I ask you, you mean inactive as not shipped anymore or is that it doesn't receive many updates recently?

[huoyaoyuan]

May I ask you, you mean inactive as not shipped anymore or is that it doesn't receive many updates recently?

It's still shipped, but hasn't received non-trivial development for a while. You an refer to the 2~3 bar of https://github.com/dotnet/runtime/tree/main/src/libraries#primary-bar .