[release/10.0] Pass /guard:cf to Linker in aspnetcoreCA #64293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Nov 10, 2025
| <ModuleDefinitionFile>aspnetcoreCA.def</ModuleDefinitionFile> | ||
| <ImportLibrary>$(OutDir)$(TargetName).lib</ImportLibrary> | ||
| <AdditionalOptions>/NODEFAULTLIB:MSVCRT %(AdditionalOptions)</AdditionalOptions> | ||
| <AdditionalOptions>/NODEFAULTLIB:MSVCRT /guard:cf %(AdditionalOptions)</AdditionalOptions> |
Member
There was a problem hiding this comment.
We already did this, see line 66
https://github.com/dotnet/aspnetcore/pull/63437/files
Member
There was a problem hiding this comment.
That's for ClCompile, the binskim bug advised passing it to both ClCompile & the Linker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64292 to release/10.0
/cc @wtgodbe
Pass /guard:cf to Linker in aspnetcoreCA
Summary of the changes (Less than 80 chars)
Description
{Detail}
Fixes #{bug number} (in this specific format)
Customer Impact
{Justification}
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
[Justify the selection above]
Verification
Packaging changes reviewed?
When servicing release/2.3