Skip to content

Commit d7d0dcd

Browse files
committed
build/bake: fail fast on dependency signature verification errors
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
1 parent 3415a18 commit d7d0dcd

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

.github/workflows/bake.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -262,17 +262,17 @@ jobs:
262262
const sigstore = new Sigstore();
263263
264264
for (const image of core.getMultilineInput('images')) {
265-
await core.group(`Verifying ${image}`, async () => {
266-
try {
265+
try {
266+
await core.group(`Verifying ${image}`, async () => {
267267
await sigstore.verifyImageAttestations(image, {
268268
certificateIdentityRegexp: `^https://github.com/docker/github-builder(-experimental)?/.github/workflows/bake.yml.*$`,
269269
platform: OCI.defaultPlatform()
270270
});
271-
} catch (error) {
272-
core.setFailed(error);
273-
return;
274-
}
275-
});
271+
});
272+
} catch (error) {
273+
core.setFailed(`Failed to verify ${image}: ${error.message || error}`);
274+
break;
275+
}
276276
}
277277
-
278278
name: Set up Docker Buildx

.github/workflows/build.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,17 +266,17 @@ jobs:
266266
const sigstore = new Sigstore();
267267
268268
for (const image of core.getMultilineInput('images')) {
269-
await core.group(`Verifying ${image}`, async () => {
270-
try {
269+
try {
270+
await core.group(`Verifying ${image}`, async () => {
271271
await sigstore.verifyImageAttestations(image, {
272272
certificateIdentityRegexp: `^https://github.com/docker/github-builder(-experimental)?/.github/workflows/bake.yml.*$`,
273273
platform: OCI.defaultPlatform()
274274
});
275-
} catch (error) {
276-
core.setFailed(error);
277-
return;
278-
}
279-
});
275+
});
276+
} catch (error) {
277+
core.setFailed(`Failed to verify ${image}: ${error.message || error}`);
278+
break;
279+
}
280280
}
281281
-
282282
name: Set outputs

0 commit comments

Comments
 (0)