Skip to content

Commit 8a2628c

Browse files
wilzbachPetarKirov
authored andcommitted
Move MergeMethod into GHMerge
1 parent aa15dea commit 8a2628c

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

source/dlangbot/github.d

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -130,9 +130,9 @@ void updateGithubComment(in ref PullRequest pr, in ref GHComment comment,
130130

131131
alias LabelsAndCommits = Tuple!(Json[], "labels", Json[], "commits");
132132

133-
string labelName(MergeMethod method)
133+
string labelName(GHMerge.MergeMethod method)
134134
{
135-
final switch (method) with (MergeMethod)
135+
final switch (method) with (GHMerge.MergeMethod)
136136
{
137137
case none: return null;
138138
case merge: return "auto-merge";
@@ -141,16 +141,19 @@ string labelName(MergeMethod method)
141141
}
142142
}
143143

144-
MergeMethod autoMergeMethod(Json[] labels)
144+
GHMerge.MergeMethod autoMergeMethod(Json[] labels)
145145
{
146-
auto labelNames = labels.map!(l => l["name"].get!string);
147-
if (labelNames.canFind!(l => l == "auto-merge"))
148-
return MergeMethod.merge;
149-
else if (labelNames.canFind!(l => l == "auto-merge-squash"))
150-
return MergeMethod.squash;
151-
else if (labelNames.canFind!(l => l == "auto-merge-rebase"))
152-
return MergeMethod.rebase;
153-
return MergeMethod.none;
146+
with (GHMerge.MergeMethod)
147+
{
148+
auto labelNames = labels.map!(l => l["name"].get!string);
149+
if (labelNames.canFind!(l => l == "auto-merge"))
150+
return merge;
151+
else if (labelNames.canFind!(l => l == "auto-merge-squash"))
152+
return squash;
153+
else if (labelNames.canFind!(l => l == "auto-merge-rebase"))
154+
return rebase;
155+
return none;
156+
}
154157
}
155158

156159
auto handleGithubLabel(in ref PullRequest pr)
@@ -164,7 +167,7 @@ auto handleGithubLabel(in ref PullRequest pr)
164167
return LabelsAndCommits(labels, commits);
165168
}
166169

167-
Json[] tryMerge(in ref PullRequest pr, MergeMethod method)
170+
Json[] tryMerge(in ref PullRequest pr, GHMerge.MergeMethod method)
168171
{
169172
import std.conv : to;
170173

source/dlangbot/github_api.d

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -254,10 +254,9 @@ struct GHCiStatus
254254
// "codecov/patch", "continuous-integration/travis-ci/pr"
255255
}
256256

257-
enum MergeMethod { none = 0, merge, squash, rebase }
258-
259257
struct GHMerge
260258
{
259+
enum MergeMethod { none = 0, merge, squash, rebase }
261260
@name("commit_message") string commitMessage;
262261
string sha;
263262
@name("merge_method") @byName MergeMethod mergeMethod;

0 commit comments

Comments
 (0)