feat(table, HTML): include 'moved' resources #97
+136
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lays a foundation for including 'moved' in summarized plan out put, ultimately to address issue dineshba#95 Signed-off-by: Mike Ball <mikedball@gmail.com>
Previously, dineshba#78 introduced a change to overwrite the baked-in templates directory with a mock file system during testing. As a result, tests did not exercise the real `writer/templates/*.html` tf-summarize template logic/result. Signed-off-by: Mike Ball <mikedball@gmail.com>
Previously, the HTMLWriter tests' "CHANGE" column value was a resource name, and not the actual type of change seen in the plan. This fixes that. Signed-off-by: Mike Ball <mikedball@gmail.com>
This includes resource address moves in the resource changes in HTML table output. Signed-off-by: Mike Ball <mikedball@gmail.com>
This includes details pertaining resource moves in the markdown table output.
This includes moved resources amongst the changes in the non-markdown table output. Signed-off-by: Mike Ball <mikedball@gmail.com>
This improves the HTML table to show 'moved' resources at the bottom of the table. This also seeks to establish a better control flow pattern for other writers to emulate. Signed-off-by: Mike Ball <mikedball@gmail.com>
This seeks to enable better control/flow around moved-specific logic. Signed-off-by: Mike Ball <mikedball@gmail.com>
A move does not inherently require change actions; moves are handled separately from resource changes. Signed-off-by: Mike Ball <mikedball@gmail.com>
Contributor
Author
|
@dineshba Would you mind taking a look at this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #95 for the table and HTML writers, which now include summary of "moved" resources. This does not include moved resources for the other writers given those writers are a bit more minimal in their summary, which doesn't even include output changes.