ENHANCE: filter builder to allow combinate several filters and insure efficiency when query parameters are generated

Author: sylvainraye

src/Filter/FilterBuilder.php

@@ -14,13 +14,17 @@ class FilterBuilder implements FilterBuilderInterface
     /** @var FilterInterface */
     protected $filter;
 
-    public function __construct(FilterInterface $filter)
+    public function __construct(FilterInterface ...$filters)
     {
-        $this->filter = $filter;
+        $this->filters = $filters;
     }
 
     public function __invoke(): array
     {
-        return $this->filter->getCriteria() ?? [];
+        $criteria = [];
+        foreach ($this->filters as $filter) {
+            $criteria = array_merge($criteria, $filter->getCriteria());
+        }
+        return $criteria;
     }
 }

src/Filter/FilterBuilderInterface.php

@@ -13,7 +13,7 @@
 
 interface FilterBuilderInterface
 {
-    public function __construct(FilterInterface $filter);
+    public function __construct(FilterInterface ...$filters);
 
     public function __invoke(): array;
 }

test/Filter.php

@@ -9,6 +9,8 @@
 
 namespace Diglin\Sylius\ApiClient\Test;
 
+use Diglin\Sylius\ApiClient\Filter\FilterBuilder;
+use Diglin\Sylius\ApiClient\Routing\UriGenerator;
 use PHPUnit\Framework\TestCase;
 
 class Filter extends TestCase
@@ -22,4 +24,15 @@ public function testFilter()
         $this->assertArrayHasKey('criteria[date][from][date]', $criteria);
         $this->assertEquals('2021-02-04', $criteria['criteria[date][from][date]']);
     }
+
+    public function testFilterBuilder()
+    {
+        $builder = (new FilterBuilder(
+            new \Diglin\Sylius\ApiClient\Filter\Filter('channel', 1),
+            new \Diglin\Sylius\ApiClient\Filter\Filter(['date'=> ['from' => ['date' => '2021-02-04']]])
+        ));
+
+        $criteria = $builder();
+        $this->assertCount(2, $criteria);
+    }
 }