Reduce the number of call to API if not needed in case of the XAuth Token Header is not present

sylvainraye · sylvainraye · commit 7b50d491316d · 2020-09-21T20:43:07.000+02:00
diff --git a/src/Client/AuthenticatedHttpClient.php b/src/Client/AuthenticatedHttpClient.php
@@ -45,11 +45,15 @@ public function __construct(
     public function sendRequest($httpMethod, $uri, array $headers = [], $body = null)
     {
         try {
+            $xauthtokenDetected = false;
             foreach ((array) $this->authentication->getXauthtokenHeader() as $name => $value) {
                 $headers[$name] = $value;
+                $xauthtokenDetected = true;
             }
 
-            return $this->basicHttpClient->sendRequest($httpMethod, $uri, $headers, $body);
+            if ($xauthtokenDetected) {
+                return $this->basicHttpClient->sendRequest($httpMethod, $uri, $headers, $body);
+            }
         } catch (UnauthorizedHttpException $e) {
             // Do nothing and process to standard authentication
         }

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,15 @@ public function __construct(`
`45`	`45`	`public function sendRequest($httpMethod, $uri, array $headers = [], $body = null)`
`46`	`46`	`{`
`47`	`47`	`try {`
	`48`	`+ $xauthtokenDetected = false;`
`48`	`49`	`foreach ((array) $this->authentication->getXauthtokenHeader() as $name => $value) {`
`49`	`50`	`$headers[$name] = $value;`
	`51`	`+ $xauthtokenDetected = true;`
`50`	`52`	`}`
`51`	`53`
`52`		`- return $this->basicHttpClient->sendRequest($httpMethod, $uri, $headers, $body);`
	`54`	`+ if ($xauthtokenDetected) {`
	`55`	`+ return $this->basicHttpClient->sendRequest($httpMethod, $uri, $headers, $body);`
	`56`	`+ }`
`53`	`57`	`} catch (UnauthorizedHttpException $e) {`
`54`	`58`	`// Do nothing and process to standard authentication`
`55`	`59`	`}`