Skip to content

Commit 954e4c6

Browse files
authored
Merge pull request #606 from digital-preservation/DR2-2520_RemoveBlankSpaceBetweenSettingsAndValidate
Dr2 2520 remove the large blank space between "Settings" and "Validate" button
2 parents e300fbd + 7a62b5a commit 954e4c6

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ The Validation tool and APIs are written in Scala 2.13 and may be used as:
2020

2121
* A library in your Scala project.
2222

23-
* A library in your Java project (We provide a Java 11 interface, to make things simple for Java programmers too).
23+
* A library in your Java project (We provide a Java 21 interface, to make things simple for Java programmers too).
2424

25-
The Validation Tool and APIs can be used on any Java Virtual Machine which supports Java 11 or better (**NB Java 6 support was removed in version 1.1**). The source code is
25+
The Validation Tool and APIs can be used on any Java Virtual Machine which supports Java 21 or better (**NB Java 6 support was removed in version 1.1**). The source code is
2626
built using the [Apache Maven](https://maven.apache.org/) build tool:
2727

2828
1. For use in other Java/Scala Applications, build by executing `mvn clean install`.
@@ -41,7 +41,7 @@ If you wish to use the CSV Validator from your own Java project, we provide a na
4141
<dependency>
4242
<groupId>uk.gov.nationalarchives</groupId>
4343
<artifactId>csv-validator-java-api</artifactId>
44-
<version>1.4.0</version>
44+
<version>1.4.1</version>
4545
</dependency>
4646
```
4747

@@ -109,7 +109,7 @@ Likewise, if you wish to use the CSV Validator from your own Scala project, the
109109
<dependency>
110110
<groupId>uk.gov.nationalarchives</groupId>
111111
<artifactId>csv-validator-core</artifactId>
112-
<version>1.3.0</version>
112+
<version>1.4.1</version>
113113
</dependency>
114114
```
115115

csv-validator-distribution/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ This module assembles the csv-validator deliverable in a zip format.
55

66
---
77
### Structure of the generated ZIP file
8-
The zip, which includes bundled JRE, has following structure.
8+
The zip, which includes bundled JRE, has the following structure:
99

1010
```
1111
csv-validator-application-<version_number>

csv-validator-ui/src/main/scala/uk/gov/nationalarchives/csv/validator/ui/CsvValidatorUi.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ object CsvValidatorUi extends SimpleSwingApplication {
7171
//handle resizing the main window, when resizing the settings panel
7272
settings.settingsGroup.reactions += SJXTaskPane.onViewStateChanged {
7373
this.preferredSize = this.size
74+
if (settings.settingsGroup.collapsed) settings.settingsGroup.remove(settings.settingsGroupLayout)
75+
else settings.settingsGroup.add(settings.settingsGroupLayout)
76+
7477
this.pack()
7578
}
7679
new ContentPanel(settings, this)
@@ -582,7 +585,7 @@ object CsvValidatorUi extends SimpleSwingApplication {
582585
btnRemovePathSubstitution.reactions += onClick(tblPathSubstitutions.removeSelectedRows())
583586
btnAddPathSubstitution.reactions += onClick(tablePathDialog())
584587

585-
private val settingsGroupLayout = new GridBagPanel {
588+
val settingsGroupLayout: GridBagPanel = new GridBagPanel {
586589
private val c = new Constraints
587590
c.anchor = Anchor.West
588591

@@ -658,7 +661,6 @@ object CsvValidatorUi extends SimpleSwingApplication {
658661
c.anchor = Anchor.LastLineEnd
659662
layout(btnAddPathSubstitution) = c
660663
}
661-
settingsGroup.add(settingsGroupLayout)
662664

663665
add(settingsGroup)
664666

csv-validator-ui/src/main/scala/uk/gov/nationalarchives/csv/validator/ui/SJXHelpers.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ class SJXTaskPane(title: String) extends Panel with Publisher {
4444
this.collapsed = collapsed
4545
}
4646
def add(component: Component) = peer.add(component.peer)
47+
def remove(component: Component) = peer.remove(component.peer)
4748
def collapsed = peer.isCollapsed
4849
def collapsed_= (c : Boolean) : Unit = {
4950
peer.setCollapsed(c)

0 commit comments

Comments
 (0)