Skip to content

Commit a73c660

Browse files
author
PJEstrada
authored
Merge pull request #22 from diffgram/rename-url-cached-vars
feat: add env variable for url caching in seconds
2 parents 3f0f66a + fb9bdcc commit a73c660

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

templates/diffgram_settings.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
DIFFGRAM_STATIC_STORAGE_PROVIDER: {{ .Values.diffgramSettings.DIFFGRAM_STATIC_STORAGE_PROVIDER }}
55
DIFFGRAM_S3_BUCKET_NAME: {{ .Values.diffgramSettings.DIFFGRAM_S3_BUCKET_NAME }}
66
IS_DIFFGRAM_S3_V4_SIGNATURE: {{ .Values.diffgramSettings.IS_DIFFGRAM_S3_V4_SIGNATURE }}
7-
SIGNED_URL_CACHE_MINIMUM_DAYS_VALID: {{ .Values.diffgramSettings.SIGNED_URL_CACHE_MINIMUM_DAYS_VALID }}
8-
SIGNED_URL_CACHE_NEW_OFFSET_DAYS_VALID: {{ .Values.diffgramSettings.SIGNED_URL_CACHE_NEW_OFFSET_DAYS_VALID }}
7+
SIGNED_URL_CACHE_MINIMUM_SECONDS_VALID: {{ .Values.diffgramSettings.SIGNED_URL_CACHE_MINIMUM_SECONDS_VALID }}
8+
SIGNED_URL_CACHE_NEW_OFFSET_SECONDS_VALID: {{ .Values.diffgramSettings.SIGNED_URL_CACHE_NEW_OFFSET_SECONDS_VALID }}
99
DIFFGRAM_S3_BUCKET_REGION: {{ .Values.diffgramSettings.DIFFGRAM_S3_BUCKET_REGION }}
1010
ML__DIFFGRAM_S3_BUCKET_NAME: {{ .Values.diffgramSettings.ML__DIFFGRAM_S3_BUCKET_NAME }}
1111
GOOGLE_APPLICATION_CREDENTIALS: /etc/gcp/sa_credentials.json # Check the volume in deployment.yaml and service_account_secret.yaml

values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ diffgramSettings:
101101
RABBITMQ_PORT: "'5672'"
102102
RABBITMQ_HOST: "diffgram-rabbitmq"
103103
RABBITMQ_USE_SSL: '"False"'
104-
SIGNED_URL_CACHE_MINIMUM_DAYS_VALID: "'5'"
105-
SIGNED_URL_CACHE_NEW_OFFSET_DAYS_VALID: "'6'"
104+
SIGNED_URL_CACHE_MINIMUM_SECONDS_VALID: "'18000'" # 5 days default
105+
SIGNED_URL_CACHE_NEW_OFFSET_SECONDS_VALID: "'21600'" # 6 days default
106106

107107
# Email Settings
108108
EMAIL_VALIDATION: '"False"' # Turns on email verification for new accounts.

0 commit comments

Comments
 (0)