From b88d2392ea084646df468535e0660db66ec08214 Mon Sep 17 00:00:00 2001 From: "devsy-app[bot]" <277138668+devsy-app[bot]@users.noreply.github.com> Date: Sat, 15 Aug 2026 11:41:54 +0000 Subject: [PATCH 1/2] test(file): cover IsLocalDir branches pkg/file had no tests. Add table-style coverage for IsLocalDir: existing dir, existing file, relative path resolves to absolute, and non-existent path returns the name unchanged. No behavioral change. --- pkg/file/file_test.go | 75 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 pkg/file/file_test.go diff --git a/pkg/file/file_test.go b/pkg/file/file_test.go new file mode 100644 index 000000000..8ae35b8c7 --- /dev/null +++ b/pkg/file/file_test.go @@ -0,0 +1,75 @@ +package file + +import ( + "os" + "path/filepath" + "testing" +) + +func TestIsLocalDirExistingDirectory(t *testing.T) { + dir := t.TempDir() + abs, err := filepath.Abs(dir) + if err != nil { + t.Fatalf("abs: %v", err) + } + + isLocal, name := IsLocalDir(dir) + if !isLocal { + t.Fatalf("IsLocalDir(%q) = false, want true", dir) + } + if name != abs { + t.Fatalf("name = %q, want %q", name, abs) + } +} + +func TestIsLocalDirExistingFile(t *testing.T) { + dir := t.TempDir() + path := filepath.Join(dir, "file.txt") + if err := os.WriteFile(path, []byte("x"), 0o600); err != nil { + t.Fatalf("write: %v", err) + } + abs, err := filepath.Abs(path) + if err != nil { + t.Fatalf("abs: %v", err) + } + + isLocal, name := IsLocalDir(path) + if !isLocal { + t.Fatalf("IsLocalDir(%q) = false, want true", path) + } + if name != abs { + t.Fatalf("name = %q, want %q", name, abs) + } +} + +func TestIsLocalDirRelativePathResolvesToAbsolute(t *testing.T) { + root := t.TempDir() + t.Chdir(root) + + if err := os.Mkdir("relsub", 0o755); err != nil { + t.Fatalf("mkdir: %v", err) + } + + isLocal, name := IsLocalDir("relsub") + if !isLocal { + t.Fatalf("IsLocalDir(%q) = false, want true", "relsub") + } + if !filepath.IsAbs(name) { + t.Fatalf("name = %q, want an absolute path", name) + } + if resolved, err := filepath.Abs("relsub"); err == nil && name != resolved { + t.Fatalf("name = %q, want %q", name, resolved) + } +} + +func TestIsLocalDirNonExistentPathReturnsNameUnchanged(t *testing.T) { + missing := filepath.Join(t.TempDir(), "does-not-exist") + + isLocal, name := IsLocalDir(missing) + if isLocal { + t.Fatalf("IsLocalDir(%q) = true, want false", missing) + } + if name != missing { + t.Fatalf("name = %q, want %q", name, missing) + } +} From 576c9ba3b527e655b97a034ab25799e031c0f8e8 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sun, 16 Aug 2026 15:41:23 -0500 Subject: [PATCH 2/2] fix: lint error --- pkg/file/file_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/file/file_test.go b/pkg/file/file_test.go index 8ae35b8c7..c4dd223d5 100644 --- a/pkg/file/file_test.go +++ b/pkg/file/file_test.go @@ -46,6 +46,7 @@ func TestIsLocalDirRelativePathResolvesToAbsolute(t *testing.T) { root := t.TempDir() t.Chdir(root) + //nolint:gosec if err := os.Mkdir("relsub", 0o755); err != nil { t.Fatalf("mkdir: %v", err) }