Skip to content

Commit af9d914

Browse files
committed
Change String concatenation with "+" to individual print statements.
This saves some memory since concatenating Strings means copying. Also see Issue #20
1 parent 62e7cce commit af9d914

File tree

1 file changed

+14
-14
lines changed

1 file changed

+14
-14
lines changed

plotter/Plotter.cpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -167,15 +167,15 @@ void Plotter::Plot()
167167
{
168168
bool config = counter == 0;
169169

170-
Serial.print( "{\"" + TIME_KEY + "\":" ); Serial.print( millis() );
170+
Serial.print( "{\""); Serial.print(TIME_KEY); Serial.print("\":" ); Serial.print( millis() );
171171

172172
if ( config )
173173
{
174-
Serial.print( ",\"" + NUM_GRAPH_KEY + "\":" ); Serial.print( numGraphs );
175-
Serial.print( ",\"" + LAST_UPDATED_KEY + "\":" ); Serial.print( lastUpdated );
174+
Serial.print( ",\""); Serial.print(NUM_GRAPH_KEY); Serial.print("\":" ); Serial.print( numGraphs );
175+
Serial.print( ",\""); Serial.print(LAST_UPDATED_KEY); Serial.print("\":" ); Serial.print( lastUpdated );
176176
}
177177

178-
Serial.print( ",\"" + GRAPHS_KEY + "\":[" );
178+
Serial.print( ",\""); Serial.print(GRAPHS_KEY); Serial.print("\":[" );
179179

180180
Graph * temp = head;
181181
while ( temp )
@@ -215,26 +215,26 @@ Plotter::Graph::~Graph()
215215
void Plotter::Graph::Plot( bool config )
216216
{
217217
Serial.print( "{" );
218-
218+
219219
if ( config )
220220
{
221-
Serial.print( "\"" + TITLE_KEY + "\":" ); Serial.print( "\"" + title + "\"" );
222-
Serial.print( ",\"" + XVY_KEY + "\":" ); Serial.print( xvy );
223-
Serial.print( ",\"" + POINTS_DISPLAYED_KEY + "\":" ); Serial.print( pointsDisplayed );
224-
Serial.print( ",\"" + SIZE_KEY + "\":" ); Serial.print( size );
225-
Serial.print( ",\"" + LABELS_KEY + "\":[" );
221+
Serial.print( "\""); Serial.print(TITLE_KEY); Serial.print("\":" ); Serial.print( "\""); Serial.print(title); Serial.print("\"" );
222+
Serial.print( ",\""); Serial.print(XVY_KEY); Serial.print("\":" ); Serial.print( xvy );
223+
Serial.print( ",\""); Serial.print(POINTS_DISPLAYED_KEY); Serial.print("\":" ); Serial.print( pointsDisplayed );
224+
Serial.print( ",\""); Serial.print(SIZE_KEY); Serial.print("\":" ); Serial.print( size );
225+
Serial.print( ",\""); Serial.print(LABELS_KEY); Serial.print("\":[" );
226226
for ( int i = 0; i < size; i++ )
227227
{
228-
Serial.print( "\"" + wrappers[i].GetLabel() + "\"" );
228+
Serial.print( "\""); Serial.print(wrappers[i].GetLabel()); Serial.print("\"" );
229229
if ( i + 1 < size )
230230
{
231231
Serial.print( "," );
232232
}
233233
}
234-
Serial.print( "],\"" + COLORS_KEY + "\":[" );
234+
Serial.print( "],\""); Serial.print(COLORS_KEY); Serial.print("\":[" );
235235
for ( int i = 0; i < size; i++ )
236236
{
237-
Serial.print( "\"" + wrappers[i].GetColor() + "\"" );
237+
Serial.print( "\""); Serial.print(wrappers[i].GetColor()); Serial.print("\"" );
238238
if ( i + 1 < size )
239239
{
240240
Serial.print( "," );
@@ -243,7 +243,7 @@ void Plotter::Graph::Plot( bool config )
243243
Serial.print( "]," );
244244
}
245245

246-
Serial.print( "\"" + DATA_KEY + "\":[" );
246+
Serial.print( "\""); Serial.print(DATA_KEY); Serial.print("\":[" );
247247
for (int i = 0; i < size; i++)
248248
{
249249
Serial.print( wrappers[i].GetValue(), 8 );

0 commit comments

Comments
 (0)