Commit 8a8ec85
committed
perf(devframe): replace open with a native spawn helper
All three call sites (adapters/dev.ts, recipes/common-rpc-functions.ts,
plugins/assets's reveal-in-folder) pass a bare string target and never
use open()'s options - the npm open package is inlined via tsdown
onlyBundle with its full is-wsl/wsl-utils/run-applescript/
powershell-utils/default-browser* dependency tree, producing a ~19 KB
dist chunk for functionality a ~30-line spawn helper covers: darwin
'open', win32 'cmd /c start', linux 'xdg-open', with WSL detection
(/proc/version) preferring wslview and falling back to invoking
cmd.exe directly.
Drops the unused wait option along with the open dependency (and its
now-unreferenced transitive shims from tsdown's onlyBundle list) -
deliberate, narrow surface break; the utils/open subpath export is
unchanged. Verified the new implementation fails gracefully (ENOENT,
caught by the existing call-site try/catches) on a plain Linux
container with none of open, xdg-open, or wslview installed.1 parent 549ab4a commit 8a8ec85
7 files changed
Lines changed: 54 additions & 39 deletions
File tree
- packages/devframe
- src/utils
- tests/__snapshots__/tsnapi/devframe/utils
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
111 | 111 | | |
112 | 112 | | |
113 | 113 | | |
114 | | - | |
115 | 114 | | |
116 | 115 | | |
117 | 116 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
10 | 30 | | |
11 | 31 | | |
12 | 32 | | |
13 | 33 | | |
14 | 34 | | |
15 | 35 | | |
16 | | - | |
17 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
18 | 59 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | 39 | | |
44 | 40 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | 41 | | |
50 | 42 | | |
51 | 43 | | |
52 | 44 | | |
53 | | - | |
54 | 45 | | |
55 | 46 | | |
56 | 47 | | |
57 | | - | |
58 | | - | |
59 | 48 | | |
60 | 49 | | |
61 | 50 | | |
62 | 51 | | |
63 | 52 | | |
64 | | - | |
65 | 53 | | |
66 | 54 | | |
67 | 55 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
95 | 95 | | |
96 | 96 | | |
97 | 97 | | |
98 | | - | |
99 | 98 | | |
100 | 99 | | |
101 | 100 | | |
| |||
Lines changed: 1 addition & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | 4 | | |
11 | | - | |
| 5 | + | |
12 | 6 | | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
0 commit comments