chore: add review request

Author: antfu

packages/hub-ui/src/client/state/branding.ts

@@ -168,6 +168,7 @@ function readQueryParams(): DevframeBranding {
  * and return it. Called once the RPC client is connected, before the dock
  * element mounts, so branding is applied on the first paint.
  */
+// TODO: remove this, the branding would only be provided by the connection meta, which has its own propagation methods, no globals or queryies anymore.
 export function resolveBranding(options: {
   mode: 'embedded' | 'standalone'
   branding?: DevframeBranding

packages/hub/src/node/initiate.ts

@@ -134,6 +134,7 @@ export interface DevframeHubUi {
    * connection handshake they already perform, in place of a separate
    * fetched asset.
    */
+  // TODO: rename to "configs"
   settings?: () => Record<string, unknown>
 }
 

packages/hub/src/node/install-devframe.ts

@@ -97,6 +97,7 @@ export async function installDevframe(
   // are this devframe's opinion about the hub-wide dock bar, not attributes
   // of its own synthesized entry — pull them out before spreading the rest
   // into the entry and fold them into the hub's aggregate instead.
+  // TODO: rework this, instead of contributeDockConfig, we should have the APIs for configuring the connection meta's configs object
   const { categoryOrder, maxVisibleItems, defaultMode, defaultPosition, ...entryDockDefaults } = d.dock ?? {}
   if (categoryOrder || maxVisibleItems !== undefined || defaultMode !== undefined || defaultPosition !== undefined) {
     ctx.docks.contributeDockConfig({ categoryOrder, maxVisibleItems, defaultMode, defaultPosition })

packages/hub/src/types/docks.ts

@@ -28,6 +28,7 @@ export interface DevframeDocksHost {
     'dock:entry:updated': (entry: DevframeDockUserEntry) => void
     'dock:activate': (activation: DevframeDockActivation) => void
   }>
+  // TODO: remove this, it doesn't need to be exposed in DevframeDocksHost
   /** The aggregate dock-bar config collected from every installed devframe so far. */
   readonly dockConfig: DevframeDockConfig
   /**
@@ -37,6 +38,7 @@ export interface DevframeDocksHost {
    * `defaultMode` / `defaultPosition`. Last caller wins per scalar key;
    * `categoryOrder` shallow-merges over what's already aggregated.
    */
+  // TODO: remove this, it doesn't need to be exposed in DevframeDocksHost
   contributeDockConfig: (config: DevframeDockConfig) => void
 
   register: <T extends DevframeDockUserEntry>(entry: T, force?: boolean) => {