introduce constants for pagination limits and update logic in utils and Select component

Author: SerVitasik

adminforth/spa/src/afcl/Select.vue

@@ -187,7 +187,7 @@ function updateFromProps() {
 }
 
 async function inputClick() {
-  if (props.readonly && !props.searchDisabled) return;
+  if (props.readonly || props.searchDisabled) return;
   // Toggle local dropdown
   showDropdown.value = !showDropdown.value;
   // If the dropdown is about to close, reset the search
@@ -266,7 +266,7 @@ onMounted(() => {
 
 const filteredItems = computed(() => {
 
-  if (!props.searchDisabled) {
+  if (props.searchDisabled) {
     return props.options || [];
   }
   

adminforth/spa/src/utils.ts

@@ -10,6 +10,8 @@ import sanitizeHtml  from 'sanitize-html'
 import debounce from 'debounce';
 
 const LS_LANG_KEY = `afLanguage`;
+const MAX_CONSECUTIVE_EMPTY_RESULTS = 2;
+const ITEMS_PER_PAGE_LIMIT = 100;
 
 export async function callApi({path, method, body=undefined}: {
   path: string, method: 'GET' | 'POST' | 'PUT' | 'DELETE' | 'PATCH' 
@@ -233,7 +235,7 @@ export function handleForeignResourcePagination(
       if (items.length === 0) {
         const newEmptyCount = emptyResultsCount + 1;
         return {
-          hasMore: newEmptyCount < 2, // Stop loading after 2 consecutive empty results
+          hasMore: newEmptyCount < MAX_CONSECUTIVE_EMPTY_RESULTS, // Stop loading after 2 consecutive empty results
           emptyResultsCount: newEmptyCount
         };
       } else {
@@ -245,7 +247,7 @@ export function handleForeignResourcePagination(
     }
   } else {
     return {
-      hasMore: items.length === 100,
+      hasMore: items.length === ITEMS_PER_PAGE_LIMIT,
       emptyResultsCount: 0
     };
   }