Merge pull request #467 from devforth/feature/AdminForth/1193/i-think-we-had-some-feature-wh

feat: add default user detection and private IP check to AdminForthRe…

Author: SerVitasik

adminforth/modules/restApi.ts

@@ -376,6 +376,13 @@ export default class AdminForthRestAPI implements IAdminForthRestAPI {
           }
         }
 
+      let defaultUserExists = false;
+        if (username === 'adminforth') {
+          defaultUserExists = true;
+        }
+      const clientIp = this.adminforth.auth.getClientIp(response.getHeaders?.() || {});
+      const isPrivateIP = clientIp === null ? true : false;
+
         const publicPart = {
           brandName: this.adminforth.config.customization.brandName,
           usernameFieldName: usernameColumn.label,
@@ -404,6 +411,7 @@ export default class AdminForthRestAPI implements IAdminForthRestAPI {
           globalInjections: this.adminforth.config.customization.globalInjections,
           userFullnameField: this.adminforth.config.auth.userFullNameField,
           settingPages: settingPages,
+          hasDefaultUserOnPublicNetwork: defaultUserExists && !isPrivateIP
         }
 
         // translate menu labels

adminforth/spa/src/components/Sidebar.vue

@@ -51,6 +51,11 @@
         </div>
       </div>
 
+     <div v-if="coreStore.config.hasDefaultUserOnPublicNetwork" class="p-4 mb-4 text-white rounded-lg bg-red-700/80 fill-white text-sm"> 
+      <IconExclamationCircleOutline class="inline-block align-text-bottom mr-0,5 w-5 h-5" />
+      Default user <strong>"adminforth"</strong> detected. Delete it and create your own account.
+    </div>
+
       <ul class="af-sidebar-container space-y-2 font-medium" >
       <template v-if="!iconOnlySidebarEnabled || !isSidebarIconOnly" v-for="(item, i) in coreStore.menu" :key="`menu-${i}`">
           <div v-if="item.type === 'divider'" class="border-t border-lightSidebarDevider dark:border-darkSidebarDevider"></div>
@@ -300,6 +305,7 @@ import { getIcon, verySimpleHash, loadFile, getCustomComponent } from '@/utils';
 import { Tooltip } from '@/afcl';
 import type { AnnouncementBadgeResponse } from '@/types/Common';
 import { useAdminforth } from '@/adminforth';
+import { IconExclamationCircleOutline} from '@iconify-prerendered/vue-flowbite';
 
 const { menu } = useAdminforth();
 

adminforth/types/Common.ts

@@ -1117,6 +1117,7 @@ export interface AdminForthConfigForFrontend {
   loginBackgroundImage: string,
   loginBackgroundPosition: string,
   removeBackgroundBlendMode: boolean,
+  defaultUserExists?: boolean;
   title?: string,
   demoCredentials?: string,
   loginPromptHTML?: string | (() => string | Promise<string> | void | Promise<void> | Promise<undefined>) | undefined