From 2b21d409a1c3d9f4268a636b0c891c93f32a2aad Mon Sep 17 00:00:00 2001 From: Ales Raszka Date: Wed, 28 Jan 2026 16:15:13 +0100 Subject: [PATCH] Fix: check for empty storage in common storage provisioner The NeedsStorage always return false for per-wokrspace storage. This causes an issue and per-workspace workspaces are never backed up. Moving the check to commonStorage only fixes the issue and still works with empty workspaces. Signed-off-by: Ales Raszka --- pkg/library/storage/storage.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/library/storage/storage.go b/pkg/library/storage/storage.go index f32aecb91..9ccfa7f81 100644 --- a/pkg/library/storage/storage.go +++ b/pkg/library/storage/storage.go @@ -49,16 +49,16 @@ func GetWorkspacePVCInfo( if err != nil { return "", "", err } - if !storageProvisioner.NeedsStorage(&workspace.Spec.Template) { - // No storage provisioned for this workspace - return "", "", nil - } if _, ok := storageProvisioner.(*storage.PerWorkspaceStorageProvisioner); ok { pvcName := common.PerWorkspacePVCName(workspace.Status.DevWorkspaceId) return pvcName, constants.DefaultProjectsSourcesRoot, nil } else if _, ok := storageProvisioner.(*storage.CommonStorageProvisioner); ok { + if !storageProvisioner.NeedsStorage(&workspace.Spec.Template) { + // No storage provisioned for this workspace + return "", "", nil + } pvcName := constants.DefaultWorkspacePVCName if config.Workspace != nil && config.Workspace.PVCName != "" { pvcName = config.Workspace.PVCName