Ik/codespaces script improvements #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove duplicate call show_ready_message in the end of file
collymore
reviewed
Dec 1, 2025
| # Fix for missing sample data media files | ||
| # ====================================================================================== | ||
| if [ "${INSTALL_SAMPLE_DATA}" = "YES" ]; then | ||
| if [ "${INSTALL_SAMPLE_DATA}" = "YES" ] && [ "${PLATFORM_NAME}" = "mage-os" ]; then |
Member
There was a problem hiding this comment.
Sample data can be installed on both platforms.
Revert this back to
if [ "${INSTALL_SAMPLE_DATA}" = "YES" ]; then
Then use the platform_name value here
SAMPLE_MEDIA_SOURCE="vendor/${PLATFORM_NAME}/sample-data-media"
Collaborator
Author
There was a problem hiding this comment.
I understand you, but this fix is only for MageOS, meaning there’s no such issue for Luma.
So this condition is completely justified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.