Skip to content

Commit e702882

Browse files
Apply suggestions from code review
Co-authored-by: Brigit Murtaugh <brigit.murtaugh@microsoft.com>
1 parent 6c4e2af commit e702882

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

proposals/devcontainer-features.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ Features can be defined by a `devcontainer-feature.json` file in the root folder
88

99
By default, features are installed in an order selected by the implementing tool.
1010

11-
If any of the following properties in the feature's `devcontainer-feature.json, or the user's `devcontainer.json` are provided, the ordered indicated by the propert(ies) are respected.
11+
If any of the following properties are provided in the feature's `devcontainer-feature.json`, or the user's `devcontainer.json`, the order indicated by the propert(ies) are respected.
1212

1313
- `runsAfter` property defined as part of `devcontainer-feature.json`.
14-
- id.
14+
- `id`.
1515

16-
The tool uses the `runsAfter` propery to intelligently manage this order and ensure that if there are relationships betwen the features they are respected.
16+
The tool uses the `runsAfter` property to intelligently manage this order and ensure that if there are relationships between the features, they are respected.
1717

1818
An end-user can explicitly provide an installation order for features given the `overrideFeatureInstallOrder` property of `devcontainer.json`.
1919

@@ -152,9 +152,9 @@ A release consists of the following:
152152

153153
There are several things to keep in mind for an application that implements features:
154154

155-
- The order of execution of features is determined by the application based on the `installAfter` property by feature authors and can be overriden by users if necesarry with the `overrideFeatureInstallOrder` in `devcontainer.json`.
155+
- The order of execution of features is determined by the application, based on the `installAfter` property used by feature authors. It can be overridden by users if necessary with the `overrideFeatureInstallOrder` in `devcontainer.json`.
156156
- Features are used to create an image that can be used to create a container or not.
157-
- Parameters like `privileged`, `init` are included if just 1 feature requires them.
158-
- Parameters like `capAdd`, `securityOp` are concatenated.
159-
- ContainerEnv is added before the feature is executed as `ENV` commands in the docker file.
157+
- Parameters like `privileged` and `init` are included if just 1 feature requires them.
158+
- Parameters like `capAdd` and `securityOp` are concatenated.
159+
- `containerEnv` is added before the feature is executed as `ENV` commands in the Dockerfile.
160160
- Each feature script executes as its own layer to aid in caching and rebuilding.

0 commit comments

Comments
 (0)