Add ReturnTypeWillChange attribute to offsetGet

mr-chetan · davidbyoung · mr-chetan · commit f83929a7ee57 · 2025-08-24T17:58:39.000+05:30
Added the #[ReturnTypeWillChange] attribute to the offsetGet method in Collection to ensure compatibility with future PHP versions and suppress deprecation warnings. https: //github.com/paquettg/pull/291 https: //github.com/paquettg/issues/290 Co-Authored-By: David Young <6652430+davidbyoung@users.noreply.github.com>
diff --git a/src/PHPHtmlParser/Dom/Node/Collection.php b/src/PHPHtmlParser/Dom/Node/Collection.php
@@ -9,6 +9,7 @@
 use Countable;
 use IteratorAggregate;
 use PHPHtmlParser\Exceptions\EmptyCollectionException;
+use ReturnTypeWillChange;
 
 use function call_user_func_array;
 use function count;
@@ -133,6 +134,7 @@ public function offsetUnset($offset): void
      *
      * @param  mixed  $offset
      */
+    #[ReturnTypeWillChange]
     public function offsetGet($offset): mixed
     {
         return $this->collection[$offset] ?? null;

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`use Countable;`
`10`	`10`	`use IteratorAggregate;`
`11`	`11`	`use PHPHtmlParser\Exceptions\EmptyCollectionException;`
	`12`	`+use ReturnTypeWillChange;`
`12`	`13`
`13`	`14`	`use function call_user_func_array;`
`14`	`15`	`use function count;`
`@@ -133,6 +134,7 @@ public function offsetUnset($offset): void`
`133`	`134`	`*`
`134`	`135`	`* @param mixed $offset`
`135`	`136`	`*/`
	`137`	`+ #[ReturnTypeWillChange]`
`136`	`138`	`public function offsetGet($offset): mixed`
`137`	`139`	`{`
`138`	`140`	`return $this->collection[$offset] ?? null;`