Merge pull request #9 from KMI-Learning/fix_#8

Fix #8

Author: rarenerd

.rubocop.yml

@@ -21,3 +21,6 @@ Metrics/PerceivedComplexity:
   Max: 10
 Metrics/AbcSize:
   Max: 29
+Style/MethodMissing:
+  Exclude:
+    - 'libraries/process_env_var.rb'

controls/1_4_master_node_configuration_files.rb

@@ -210,7 +210,7 @@
         throw :stop
       end
 
-      if (data_dir = file("/proc/#{etcd_process.pids.first}/environ").content.split("\0").select { |i| i[/^ETCD_DATA_DIR/] }.first.split('=').last)
+      if (data_dir = file("/proc/#{etcd_process.pids.first}/environ").content.split("\0").select { |i| i[/^ETCD_DATA_DIR/] }.first.to_s.split('=', 2).last.to_s)
         throw :stop
       end
     end
@@ -245,7 +245,7 @@
         throw :stop
       end
 
-      if (data_dir = file("/proc/#{etcd_process.pids.first}/environ").content.split("\0").select { |i| i[/^ETCD_DATA_DIR/] }.first.split('=').last)
+      if (data_dir = file("/proc/#{etcd_process.pids.first}/environ").content.split("\0").select { |i| i[/^ETCD_DATA_DIR/] }.first.to_s.split('=', 2).last.to_s)
         throw :stop
       end
     end

libraries/process_env_var.rb

@@ -29,25 +29,25 @@ def initialize(process)
   end
 
   def method_missing(name)
-    read_params[name.to_s]
+    read_params[name.to_s] || ''
   end
 
   def read_params
     return @params if defined?(@params)
 
-    proc_environ = inspec.file("/proc/#{@process.pids.first}/environ")
-    unless file.file?
+    @file = inspec.file("/proc/#{@process.pids.first}/environ")
+    unless @file.file?
       skip_resource "Can't find environ file for #{@process}"
       return @params = {}
     end
 
-    environ_content = proc_environ.content
-    if content.empty? && !file.empty?
+    @content = @file.content
+    if @content.empty? && !@file.empty?
       skip_resource "Can't read environ file for #{@process}"
       return @params = {}
     end
 
-    @params = environ_content.split("\0").map { |i| i.split('=') }.to_h
+    @params = @content.split("\0").map { |i| i.split('=', 2) }.to_h
   end
 
   def to_s