Skip to content

Commit d93c8a4

Browse files
authored
Merge pull request #67 from deploymenttheory/dev
Refactor rate limit header parsing and add test cases***
2 parents a1e2e24 + 04d31e6 commit d93c8a4

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

httpclient/httpclient_rate_handler_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ func TestCalculateBackoff(t *testing.T) {
3737
}
3838
}
3939

40-
// TestParseRateLimitHeaders tests parsing of rate limit headers and calculation of wait duration
4140
func TestParseRateLimitHeaders(t *testing.T) {
4241
tests := []struct {
4342
name string
@@ -54,7 +53,7 @@ func TestParseRateLimitHeaders(t *testing.T) {
5453
{
5554
name: "RetryAfterHTTPDate",
5655
headers: map[string]string{
57-
"Retry-After": http.TimeFormat, // Use current time for simplicity
56+
"Retry-After": time.Now().UTC().Format(time.RFC1123), // Use current time in RFC1123 format
5857
},
5958
expectedWait: 0, // Immediate retry since the date is current
6059
},

logger/zaplogger_logger_test.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func TestDefaultLogger_Warn(t *testing.T) {
105105
dLogger := &defaultLogger{logger: mockLogger.Logger, logLevel: LogLevelWarn}
106106

107107
expectedMessage := "warn message"
108-
mockLogger.On("Warn", expectedMessage, mock.Anything).Once()
108+
mockLogger.On("Warn", expectedMessage, []zapcore.Field(nil)).Once()
109109

110110
dLogger.Warn(expectedMessage)
111111

@@ -136,9 +136,11 @@ func TestDefaultLogger_Panic(t *testing.T) {
136136
mockLogger := NewMockLogger()
137137
dLogger := &defaultLogger{logger: mockLogger.Logger, logLevel: LogLevelPanic}
138138

139-
mockLogger.On("Panic", "panic message", mock.Anything).Once()
139+
expectedMessage := "panic message"
140+
mockLogger.On("Panic", expectedMessage, mock.Anything).Once()
140141

141-
assert.Panics(t, func() { dLogger.Panic("panic message") }, "The Panic method should trigger a panic")
142+
// Assert that calling Panic method triggers a panic
143+
assert.Panics(t, func() { dLogger.Panic(expectedMessage) }, "The Panic method should trigger a panic")
142144

143145
mockLogger.AssertExpectations(t)
144146
}

0 commit comments

Comments
 (0)