Refactor RedactSensitiveHeaderData function to handle sensitive data redaction

Author: ShocOne

httpclient/httpclient_headers.go

@@ -155,3 +155,19 @@ func CheckDeprecationHeader(resp *http.Response, log logger.Logger) {
 		)
 	}
 }
+
+// RedactSensitiveHeaderData redacts sensitive data if the HideSensitiveData flag is set to true.
+func RedactSensitiveHeaderData(client *Client, key string, value string) string {
+	if client.clientConfig.ClientOptions.HideSensitiveData {
+		// Define sensitive data keys that should be redacted.
+		sensitiveKeys := map[string]bool{
+			"AccessToken":   true,
+			"Authorization": true,
+		}
+
+		if _, found := sensitiveKeys[key]; found {
+			return "REDACTED"
+		}
+	}
+	return value
+}

httpclient/httpclient_headers_test.go

@@ -142,3 +142,34 @@ func TestSetCustomHeader(t *testing.T) {
 	SetCustomHeader(req, "X-Custom-Header", "CustomValue")
 	assert.Equal(t, "CustomValue", req.Header.Get("X-Custom-Header"))
 }
+
+// TestRedactSensitiveData tests the RedactSensitiveData function with various scenarios
+func TestRedactSensitiveData(t *testing.T) {
+	tests := []struct {
+		name            string
+		hideSensitive   bool
+		key             string
+		value           string
+		expectedOutcome string
+	}{
+		{"RedactSensitiveKey", true, "AccessToken", "secret-token", "REDACTED"},
+		{"RedactSensitiveKeyAuthorization", true, "Authorization", "Bearer secret-token", "REDACTED"},
+		{"DoNotRedactNonSensitiveKey", true, "NonSensitiveKey", "non-sensitive-value", "non-sensitive-value"},
+		{"DoNotRedactWhenDisabled", false, "AccessToken", "secret-token", "secret-token"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			client := &Client{
+				clientConfig: ClientConfig{
+					ClientOptions: ClientOptions{
+						HideSensitiveData: tt.hideSensitive,
+					},
+				},
+			}
+
+			result := RedactSensitiveHeaderData(client, tt.key, tt.value)
+			assert.Equal(t, tt.expectedOutcome, result, "Redaction outcome should match expected")
+		})
+	}
+}

httpclient/httpclient_helpers.go

@@ -9,19 +9,3 @@ import (
 func ParseISO8601Date(dateStr string) (time.Time, error) {
 	return time.Parse(time.RFC3339, dateStr)
 }
-
-// RedactSensitiveHeaderData redacts sensitive data if the HideSensitiveData flag is set to true.
-func RedactSensitiveHeaderData(client *Client, key string, value string) string {
-	if client.clientConfig.ClientOptions.HideSensitiveData {
-		// Define sensitive data keys that should be redacted.
-		sensitiveKeys := map[string]bool{
-			"AccessToken":   true,
-			"Authorization": true,
-		}
-
-		if _, found := sensitiveKeys[key]; found {
-			return "REDACTED"
-		}
-	}
-	return value
-}

httpclient/httpclient_helpers_test.go

@@ -44,34 +44,3 @@ func TestParseISO8601Date(t *testing.T) {
 		})
 	}
 }
-
-// TestRedactSensitiveData tests the RedactSensitiveData function with various scenarios
-func TestRedactSensitiveData(t *testing.T) {
-	tests := []struct {
-		name            string
-		hideSensitive   bool
-		key             string
-		value           string
-		expectedOutcome string
-	}{
-		{"RedactSensitiveKey", true, "AccessToken", "secret-token", "REDACTED"},
-		{"RedactSensitiveKeyAuthorization", true, "Authorization", "Bearer secret-token", "REDACTED"},
-		{"DoNotRedactNonSensitiveKey", true, "NonSensitiveKey", "non-sensitive-value", "non-sensitive-value"},
-		{"DoNotRedactWhenDisabled", false, "AccessToken", "secret-token", "secret-token"},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			client := &Client{
-				clientConfig: ClientConfig{
-					ClientOptions: ClientOptions{
-						HideSensitiveData: tt.hideSensitive,
-					},
-				},
-			}
-
-			result := RedactSensitiveHeaderData(client, tt.key, tt.value)
-			assert.Equal(t, tt.expectedOutcome, result, "Redaction outcome should match expected")
-		})
-	}
-}