tests: Use symfony/phpunit-bridge

PHPUnit 7 is not compatible with PHP 8 and PHPUnit 8 adds return annotations to setUp method,
requiring us to add those as well to pass return covariance checks.
We can bypass that by renaming the setUp methods and using @before annotations
but then there are other issues as well. For example, recent PHPUnit no longer supports
@expectexception annotations an other issues.

Let’s use Symfony’s PHPUnit bridge, which will allow us the widest range of supported PHP versions.

We will need to bump to PHP 5.6+ since that is what php-unit bridge requires
but PHP 5.4 is not even supported by Debian Jessie (oldoldstable).

Author: jtojnar

.travis.yml

@@ -1,15 +1,12 @@
 language: php
 
 php:
-  - 5.4
-  - 5.5
   - 5.6
-  - hhvm-nightly
 
 before_script:
   - composer install --dev
 
-script: phpunit --coverage-clover=coverage.clover
+script: vendor/bin/simple-phpunit --coverage-clover=coverage.clover
 
 after_script:
   - wget https://scrutinizer-ci.com/ocular.phar

composer.json

@@ -14,10 +14,10 @@
         }   
     ],
     "require": {
-        "php": ">=5.4.0"
+        "php": ">=5.6.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "~4.0"
+        "symfony/phpunit-bridge": "^5.2"
     },
     "suggest": {
         "ext-mbstring": "For using the MbTranscoder",

tests/IconvTranscoderTest.php

@@ -4,24 +4,27 @@
 
 use Ddeboer\Transcoder\IconvTranscoder;
 
-class IconvTranscoderTest extends \PHPUnit_Framework_TestCase
+class IconvTranscoderTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @var IconvTranscoder
      */
     private $transcoder;
 
-    protected function setUp()
+    /**
+     * @before
+     */
+    protected function doSetUp()
     {
         $this->transcoder = new IconvTranscoder();
+        // iconv requires a UTF-8 locale but phpunit-bridge sets it to C
+        $this->setLocale(\LC_ALL, 'C.UTF-8');
     }
 
-    /**
-     * @expectedException \Ddeboer\Transcoder\Exception\UnsupportedEncodingException
-     * @expectedExceptionMessage bad-encoding
-     */
     public function testTranscodeUnsupportedFromEncoding()
     {
+        $this->expectException(\Ddeboer\Transcoder\Exception\UnsupportedEncodingException::class);
+        $this->expectExceptionMessage('bad-encoding');
         $this->transcoder->transcode('bla', 'bad-encoding');
     }
 
@@ -30,11 +33,9 @@ public function testDetectEncoding()
         $this->transcoder->transcode('España', null, 'iso-8859-1');
     }
 
-    /**
-     * @expectedException \Ddeboer\Transcoder\Exception\IllegalCharacterException
-     */
     public function testTranscodeIllegalCharacter()
     {
+        $this->expectException(\Ddeboer\Transcoder\Exception\IllegalCharacterException::class);
         $this->transcoder->transcode('“', null, 'iso-8859-1');
     }
 

tests/MbTranscoderTest.php

@@ -4,33 +4,32 @@
 
 use Ddeboer\Transcoder\MbTranscoder;
 
-class MbTranscoderTest extends \PHPUnit_Framework_TestCase
+class MbTranscoderTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @var MbTranscoder
      */
     private $transcoder;
 
-    protected function setUp()
+    /**
+     * @before
+     */
+    protected function doSetUp()
     {
         $this->transcoder = new MbTranscoder();
     }
 
-    /**
-     * @expectedException \Ddeboer\Transcoder\Exception\UnsupportedEncodingException
-     * @expectedExceptionMessage bad-encoding
-     */
     public function testTranscodeUnsupportedFromEncoding()
     {
+        $this->expectException(\Ddeboer\Transcoder\Exception\UnsupportedEncodingException::class);
+        $this->expectExceptionMessage('bad-encoding');
         $this->transcoder->transcode('bla', 'bad-encoding');
     }
 
-    /**
-     * @expectedException \Ddeboer\Transcoder\Exception\UnsupportedEncodingException
-     * @expectedExceptionMessage bad-encoding
-     */
     public function testTranscodeUnsupportedToEncoding()
     {
+        $this->expectException(\Ddeboer\Transcoder\Exception\UnsupportedEncodingException::class);
+        $this->expectExceptionMessage('bad-encoding');
         $this->transcoder->transcode('bla', null, 'bad-encoding');
     }
 
@@ -40,12 +39,10 @@ public function testDetectEncoding()
         $this->transcoder->transcode($result);
     }
 
-    /**
-     * @expectedException \Ddeboer\Transcoder\Exception\UndetectableEncodingException
-     * @expectedExceptionMessage is undetectable 
-     */
     public function testUndetectableEncoding()
     {
+        $this->expectException(\Ddeboer\Transcoder\Exception\UndetectableEncodingException::class);
+        $this->expectExceptionMessage('is undetectable');
         $result = $this->transcoder->transcode(
             '‘curly quotes make this incompatible with 1252’',
             null,

tests/TranscoderTest.php

@@ -4,14 +4,17 @@
 
 use Ddeboer\Transcoder\Transcoder;
 
-class TranscoderTest extends \PHPUnit_Framework_TestCase
+class TranscoderTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @var Transcoder
      */
     private $transcoder;
 
-    protected function setUp()
+    /**
+     * @before
+     */
+    protected function doSetUp()
     {
         $this->transcoder = Transcoder::create();
     }