Skip to content

Assert rom_backup_data_address stays within RAM at link time #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dogruis wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

Assert rom_backup_data_address stays within RAM at link time #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions runtime/ngdevkit.ld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,16 @@ SECTIONS {
* reference is not resolved properly by the MEMORY command
*/
rom_backup_data_address = DEFINED(rom_backup_data_address)? rom_backup_data_address : 0x100000;

/* Catch overridden backup-RAM placements that would land outside the
* 60 KB of m68k work RAM. Without these guards, ld would silently lay
* out .bss.bram at whatever address was given and the runtime would
* read/write garbage on access. */
ASSERT(rom_backup_data_address >= ORIGIN(RAM),
"rom_backup_data_address is below RAM origin (0x100000)")
ASSERT(rom_backup_data_address + LENGTH(BRAM) <= ORIGIN(RAM) + LENGTH(RAM),
"rom_backup_data_address + BRAM length (0x1000) extends past RAM end")

.bss.bram rom_backup_data_address : SUBALIGN(0) {
*(.bss.bram)
. = ALIGN(4);
Expand Down