Skip to content

tests should not run on every commit #1356

@d-v-b

Description

@d-v-b

f195110 added a test workflow to pre-commit. I don't think this is a good idea.

  • pre-commit checks should be fast, and tests are not.
  • Tests are expected to fail on commits where you create a reproducer prior to committing the fix.

github workflows are a much better place for automated tests. I recommend removing tests from pre-commit checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementIndicates new improvements

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions