Merge pull request #726 from datafold/fix_conn_attrib_postgres

'PostgreSQL' object has no attribute '_conn'

Author: dlawin

data_diff/__main__.py

@@ -327,8 +327,7 @@ def main(conf, run, **kw):
             )
     except Exception as e:
         logging.error(e)
-        if kw["debug"]:
-            raise
+        raise
 
 
 def _data_diff(

data_diff/databases/postgresql.py

@@ -147,10 +147,10 @@ def create_connection(self):
 
         pg = import_postgresql()
         try:
-            c = pg.connect(**self._args)
+            self._conn = pg.connect(**self._args)
             if SESSION_TIME_ZONE:
-                c.cursor().execute(f"SET TIME ZONE '{SESSION_TIME_ZONE}'")
-            return c
+                self._conn.cursor().execute(f"SET TIME ZONE '{SESSION_TIME_ZONE}'")
+            return self._conn
         except pg.OperationalError as e:
             raise ConnectError(*e.args) from e
 

tests/test_cli.py

@@ -11,12 +11,17 @@
 
 def run_datadiff_cli(*args):
     try:
-        stdout = subprocess.check_output(
-            [sys.executable, "-m", "data_diff", "--no-tracking"] + list(args), stderr=subprocess.PIPE
+        p = subprocess.Popen(
+            [sys.executable, "-m", "data_diff", "--no-tracking"] + list(args),
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE,
         )
+        stdout, stderr = p.communicate()
     except subprocess.CalledProcessError as e:
         logging.error(e.stderr)
         raise
+    if stderr:
+        raise Exception(stderr)
     return stdout.splitlines()
 
 
@@ -48,6 +53,7 @@ def setUp(self) -> None:
     def test_basic(self):
         conn_str = CONN_STRINGS[self.db_cls]
         diff = run_datadiff_cli(conn_str, self.table_src_name, conn_str, self.table_dst_name)
+
         assert len(diff) == 1
 
     def test_options(self):