Merge pull request #333 from datafold/dec6_normalize_path

Fix _normalize_table_path to always return a pair

Author: erezsh

data_diff/sqeleton/databases/base.py

@@ -415,12 +415,11 @@ def _refine_coltypes(self, table_path: DbPath, col_dict: Dict[str, ColType], whe
 
     def _normalize_table_path(self, path: DbPath) -> DbPath:
         if len(path) == 1:
-            if self.default_schema:
-                return self.default_schema, path[0]
-        elif len(path) != 2:
-            raise ValueError(f"{self.name}: Bad table path for {self}: '{'.'.join(path)}'. Expected form: schema.table")
+            return self.default_schema, path[0]
+        elif len(path) == 2:
+            return path
 
-        return path
+        raise ValueError(f"{self.name}: Bad table path for {self}: '{'.'.join(path)}'. Expected form: schema.table")
 
     def parse_table_name(self, name: str) -> DbPath:
         return parse_table_name(name)

data_diff/sqeleton/databases/bigquery.py

@@ -158,7 +158,7 @@ def query_table_unique_columns(self, path: DbPath) -> List[str]:
 
     def parse_table_name(self, name: str) -> DbPath:
         path = parse_table_name(name)
-        return self._normalize_table_path(path)
+        return tuple(i for i in self._normalize_table_path(path) if i is not None)
 
     @property
     def is_autocommit(self) -> bool:

data_diff/sqeleton/databases/databricks.py

@@ -171,7 +171,7 @@ def _process_table_schema(
 
     def parse_table_name(self, name: str) -> DbPath:
         path = parse_table_name(name)
-        return self._normalize_table_path(path)
+        return tuple(i for i in self._normalize_table_path(path) if i is not None)
 
     @property
     def is_autocommit(self) -> bool: