diff --git a/applications/snapback/aciconfigdb.py b/applications/snapback/aciconfigdb.py index 8531a412..d3cdafb0 100644 --- a/applications/snapback/aciconfigdb.py +++ b/applications/snapback/aciconfigdb.py @@ -418,7 +418,26 @@ def take_snapshot_using_export_policy(self, callback=None): sftp.get('/home/' + self.session.uid + '/' + file_name, './' + file_name) sftp.remove('/home/' + self.session.uid + '/' + file_name) with tarfile.open(file_name, 'r:gz') as tfile: - tfile.extractall(self.repo_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tfile, self.repo_dir) os.remove(file_name) for json_filename in os.listdir(self.repo_dir): print('checking', json_filename)