Fix macOS Databricks CLI auto-install to install the correct formula#146
Closed
max-rozen-oss-db wants to merge 1 commit into
Closed
Fix macOS Databricks CLI auto-install to install the correct formula#146max-rozen-oss-db wants to merge 1 commit into
max-rozen-oss-db wants to merge 1 commit into
Conversation
On macOS the auto-installer ran `brew install databricks`, but the Databricks CLI is not in homebrew-core under that name — `databricks` resolves to an unrelated formula (the DataGrip cask), so users got the wrong tool installed. Install the fully-qualified `databricks/tap/databricks` formula instead, which resolves to the Databricks CLI and fails if the formula is missing, rather than silently falling back to the cask. Applies to both the install and upgrade paths. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
On the macOS/Homebrew path, the Databricks CLI auto-installer now installs the fully-qualified
databricks/tap/databricksformula instead ofdatabricks.Why
brew install databricksdoes not install the Databricks CLI — the CLI is published to thedatabricks/taptap, not homebrew-core. Without qualifying the tap,databricksresolves to an unrelated formula (DataGrip), so the CLI is never installed and laterdatabrickscalls fail.Using the fully-qualified formula resolves directly to the Databricks CLI and fails if the formula is missing, rather than silently falling back to the cask.
How
In
_run_databricks_cli_installer, installdatabricks/tap/databricks, matching the official Homebrew install steps. Covers both the fresh-install and auto-upgrade paths.Testing
TestRunDatabricksCliInstaller(parametrized overinstall/upgrade) pins that the macOS path invokesbrew <sub> databricks/tap/databricks.uv run pytest tests/test_databricks.py— 74 passed.uv run ruff check— clean.Closes #144