Skip to content

Commit cff04ab

Browse files
Remove legacy tag-triggered release workflow (#775)
NO_CHANGELOG=true ## Summary The secure release pipeline in [`databricks/secure-public-registry-releases-eng`](https://github.com/databricks/secure-public-registry-releases-eng) now owns the Maven Central and GitHub release for this repo. It dispatches `tagging.yml` (to create the tag) and `package.yml` (to build + sign artifacts), then does the actual publish + GH release from the secure side. The previous in-repo tag-triggered path in `release.yml` is the legacy entry point that the secure pipeline has replaced. This PR removes it and keeps only the release-build dry-run that runs on every branch push. ## Per-file decisions - `.github/workflows/release.yml` -- **edited and renamed** to `.github/workflows/release-build-check.yml` (top-level `name: Release Build Check`). - Removed: the `push.tags: ['v*']` trigger. - Removed: the tag-gated steps (`if: startsWith(github.ref, 'refs/tags/')`) -- `Publish to Maven Central Repository (Deploy)`, `Write release notes to file`, `Create GitHub release`. - Removed: the `!startsWith(...)` guard on the dry-run step (no longer needed now that the tag trigger is gone). - Preserved: the branch-push trigger and the `Run Release Dry-Run (Verify)` step, which is what "verify the release build still works" means in this repo. - `.github/workflows/debug-prelease.yml` -- **not present in the repo**, nothing to do. - `.github/workflows/tagging.yml` -- unchanged (dispatched by the secure release pipeline). - `.github/workflows/package.yml` -- unchanged (dispatched by the secure release pipeline). - All other workflows (`push.yml`, `conftest.yml`, `integration-tests.yml`, `external-message.yml`, `next-changelog.yml`) -- unchanged; they are PR / `merge_group` CI or unrelated automation. ## Heads up: required-check rename The job name inside the renamed workflow is now constant (`Run Release Dry-Run`) instead of the previous dynamic name (`${{ startsWith(github.ref, 'refs/tags/') && 'Publish Release' || 'Run Release Dry-Run' }}`). The dry-run side produced the same `Run Release Dry-Run` string before, so if anything on the branch side was using that exact name as a required status check it should continue to match. If branch protection was referencing the workflow file by path (`release.yml`), that reference will need to be updated to `release-build-check.yml`. ## Test plan - [ ] Confirm this PR's own CI (`build` from `push.yml` on `pull_request`) runs green. - [ ] On merge to `main`, confirm the renamed workflow fires on the push and the `Run Release Dry-Run` job succeeds. - [ ] Confirm no tag-push events target this workflow any longer. - [ ] Update any branch-protection required-check references from `release.yml` to `release-build-check.yml` if they existed.
1 parent 9f177da commit cff04ab

1 file changed

Lines changed: 7 additions & 40 deletions

File tree

Lines changed: 7 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1-
name: Release
1+
name: Release Build Check
22

33
on:
44
push:
5-
# Run a real release on pushes to tags like v1.0, v2.3.4, etc.
6-
tags:
7-
- "v*"
8-
# Run a dry-run on pushes to any branch
5+
# Run a release build dry-run on pushes to any branch to verify
6+
# that the release build still succeeds. Actual releases are driven
7+
# by the secure release pipeline in
8+
# databricks/secure-public-registry-releases-eng via workflow_dispatch
9+
# against tagging.yml and package.yml.
910
branches:
1011
- "**"
1112

@@ -15,8 +16,7 @@ permissions:
1516

1617
jobs:
1718
publish:
18-
# Dynamically set the job name based on the trigger
19-
name: ${{ startsWith(github.ref, 'refs/tags/') && 'Publish Release' || 'Run Release Dry-Run' }}
19+
name: Run Release Dry-Run
2020

2121
runs-on:
2222
group: databricks-protected-runner-group
@@ -82,42 +82,9 @@ jobs:
8282
</settings>
8383
EOF
8484
85-
# This step runs ONLY on branch pushes (dry-run)
8685
- name: Run Release Dry-Run (Verify)
87-
if: "!startsWith(github.ref, 'refs/tags/')"
8886
run: mvn -Prelease -DskipTests=true --batch-mode verify
8987
env:
9088
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
9189
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
9290
MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
93-
94-
# This step runs ONLY on tag pushes (real release)
95-
- name: Publish to Maven Central Repository (Deploy)
96-
if: "startsWith(github.ref, 'refs/tags/')"
97-
run: mvn -Prelease -DskipTests=true --batch-mode deploy
98-
env:
99-
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }}
100-
MAVEN_CENTRAL_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
101-
MAVEN_CENTRAL_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}
102-
103-
- name: Write release notes to file
104-
run: |
105-
if [[ "${{ github.ref }}" == refs/tags/v* ]]; then
106-
RELEASE_NOTES_DIR=/tmp/release-notes
107-
mkdir -p "$RELEASE_NOTES_DIR"
108-
RELEASE_NOTES_FILE="$RELEASE_NOTES_DIR/release-notes.md"
109-
git for-each-ref --format='%(body)' ${{ github.ref }} > "$RELEASE_NOTES_FILE"
110-
echo "Release notes file: $RELEASE_NOTES_FILE"
111-
echo "Release notes contents:"
112-
cat "$RELEASE_NOTES_FILE"
113-
else
114-
echo "Not a release tag, skipping release notes"
115-
fi
116-
117-
# This step also runs ONLY on tag pushes (real release)
118-
- name: Create GitHub release
119-
if: "startsWith(github.ref, 'refs/tags/')"
120-
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v0.1.15
121-
with:
122-
files: databricks-sdk-java/target/*.jar
123-
body_path: /tmp/release-notes/release-notes.md

0 commit comments

Comments
 (0)