feat(dart_frog_prod): detect external path dependencies (#341)

Author: felangel

bricks/dart_frog_prod_server/hooks/pre_gen.dart

@@ -26,14 +26,15 @@ Future<void> preGen(
 
   final RouteConfiguration configuration;
   try {
-    configuration = buildConfiguration(io.Directory.current);
+    configuration = buildConfiguration(projectDirectory);
   } catch (error) {
     context.logger.err('$error');
     return _exit(1);
   }
 
   reportRouteConflicts(context, configuration, _exit);
   reportRogueRoutes(context, configuration, _exit);
+  await reportExternalPathDependencies(context, projectDirectory, _exit);
 
   context.vars = {
     'directories': configuration.directories
@@ -144,6 +145,40 @@ void reportRogueRoutes(
   }
 }
 
+Future<void> reportExternalPathDependencies(
+  HookContext context,
+  io.Directory directory,
+  void Function(int exitCode) exit,
+) async {
+  final pubspec = Pubspec.parse(
+    await io.File(path.join(directory.path, 'pubspec.yaml')).readAsString(),
+  );
+
+  final dependencies = pubspec.dependencies;
+  final devDependencies = pubspec.devDependencies;
+  final pathDependencies = [...dependencies.entries, ...devDependencies.entries]
+      .where((entry) => entry.value is PathDependency)
+      .map((entry) {
+    final value = entry.value as PathDependency;
+    return [entry.key, value.path];
+  }).toList();
+  final externalDependencies = pathDependencies.where(
+    (dep) => !path.isWithin(directory.path, dep.last),
+  );
+
+  if (externalDependencies.isNotEmpty) {
+    context.logger
+      ..err('All path dependencies must be within the project.')
+      ..err('External path dependencies detected:');
+    for (final dependency in externalDependencies) {
+      final dependencyName = dependency.first;
+      final dependencyPath = path.normalize(dependency.last);
+      context.logger.err('  \u{2022} $dependencyName from $dependencyPath');
+    }
+    exit(1);
+  }
+}
+
 const _asyncRunZoned = runZoned;
 
 abstract class ExitOverrides {

bricks/dart_frog_prod_server/hooks/test/pre_gen_test.dart

@@ -399,6 +399,117 @@ dev_dependencies:
     });
   });
 
+  group('reportExternalPathDependencies', () {
+    late HookContext context;
+    late Logger logger;
+
+    setUp(() {
+      context = _MockHookContext();
+      logger = _MockLogger();
+
+      when(() => context.logger).thenReturn(logger);
+    });
+
+    test('reports nothing when there are no external path dependencies',
+        () async {
+      final exitCalls = <int>[];
+      final directory = Directory.systemTemp.createTempSync();
+      File(path.join(directory.path, 'pubspec.yaml')).writeAsStringSync(
+        '''
+name: example
+version: 0.1.0
+environment:
+  sdk: ^2.17.0
+dependencies:
+  mason: any
+dev_dependencies:
+  test: any
+''',
+      );
+      await expectLater(
+        reportExternalPathDependencies(context, directory, exitCalls.add),
+        completes,
+      );
+      verifyNever(() => logger.err(any()));
+      expect(exitCalls, isEmpty);
+      directory.delete(recursive: true).ignore();
+    });
+
+    test('reports when there is a single external path dependency', () async {
+      final exitCalls = <int>[];
+      final directory = Directory.systemTemp.createTempSync();
+      File(path.join(directory.path, 'pubspec.yaml')).writeAsStringSync(
+        '''
+name: example
+version: 0.1.0
+environment:
+  sdk: ^2.17.0
+dependencies:
+  mason: any
+  foo:
+    path: ../../foo
+dev_dependencies:
+  test: any
+''',
+      );
+      await expectLater(
+        reportExternalPathDependencies(context, directory, exitCalls.add),
+        completes,
+      );
+      expect(exitCalls, equals([1]));
+      verify(
+        () => logger.err('All path dependencies must be within the project.'),
+      ).called(1);
+      verify(
+        () => logger.err('External path dependencies detected:'),
+      ).called(1);
+      verify(
+        () => logger.err('  \u{2022} foo from ../../foo'),
+      ).called(1);
+      directory.delete(recursive: true).ignore();
+    });
+
+    test('reports when there are multiple external path dependencies',
+        () async {
+      final exitCalls = <int>[];
+      final directory = Directory.systemTemp.createTempSync();
+      File(path.join(directory.path, 'pubspec.yaml')).writeAsStringSync(
+        '''
+name: example
+version: 0.1.0
+environment:
+  sdk: ^2.17.0
+dependencies:
+  mason: any
+  foo:
+    path: ../../foo
+dev_dependencies:
+  test: any
+  bar:
+    path: ../../bar
+''',
+      );
+      await expectLater(
+        reportExternalPathDependencies(context, directory, exitCalls.add),
+        completes,
+      );
+      expect(exitCalls, equals([1]));
+      verify(
+        () => logger.err('All path dependencies must be within the project.'),
+      ).called(1);
+      verify(
+        () => logger.err('External path dependencies detected:'),
+      ).called(1);
+      verify(
+        () => logger.err('  \u{2022} foo from ../../foo'),
+      ).called(1);
+      verify(
+        () => logger.err('  \u{2022} bar from ../../bar'),
+      ).called(1);
+      directory.delete(recursive: true).ignore();
+    });
+  });
+
   group('ExitOverrides', () {
     group('runZoned', () {
       test('uses default exit when not specified', () {