feat: add byte store to improve performance (#428)

* feat: add bytestore to improve performance

* chore: fix analyzer errors

* chore: fix analyzer errors

* chore: update changelog

* chore: rename function

Author: incendial

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unpublished
+
+* Improve cli performance.
+
 ## 4.2.0-dev.3
 
 * Changed the supported `analyzer` version to `^2.1.0`.

lib/src/analyzers/lint_analyzer/lint_analyzer.dart

@@ -1,15 +1,14 @@
 import 'dart:io';
 import 'dart:math';
 
-import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/ast/ast.dart';
-import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:path/path.dart';
 
 import '../../config_builder/config_builder.dart';
 import '../../config_builder/models/analysis_options.dart';
 import '../../reporters/models/reporter.dart';
+import '../../utils/analyzer_utils.dart';
 import '../../utils/exclude_utils.dart';
 import '../../utils/file_utils.dart';
 import '../../utils/node_utils.dart';
@@ -73,11 +72,7 @@ class LintAnalyzer {
     String rootFolder,
     LintConfig config,
   ) async {
-    final collection = AnalysisContextCollection(
-      includedPaths:
-          folders.map((path) => normalize(join(rootFolder, path))).toList(),
-      resourceProvider: PhysicalResourceProvider.INSTANCE,
-    );
+    final collection = createAnalysisContextCollection(folders, rootFolder);
 
     final analyzerResult = <LintFileReport>[];
 

lib/src/analyzers/unused_files_analyzer/unused_files_analyzer.dart

@@ -1,14 +1,13 @@
 import 'dart:io';
 
-import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
 import 'package:analyzer/dart/analysis/results.dart';
 import 'package:analyzer/dart/analysis/utilities.dart';
-import 'package:analyzer/file_system/physical_file_system.dart';
 import 'package:path/path.dart';
 
 import '../../config_builder/config_builder.dart';
 import '../../config_builder/models/analysis_options.dart';
 import '../../reporters/models/reporter.dart';
+import '../../utils/analyzer_utils.dart';
 import '../../utils/file_utils.dart';
 import 'models/unused_files_file_report.dart';
 import 'reporters/reporter_factory.dart';
@@ -32,11 +31,7 @@ class UnusedFilesAnalyzer {
     String rootFolder,
     UnusedFilesConfig config,
   ) async {
-    final collection = AnalysisContextCollection(
-      includedPaths:
-          folders.map((path) => normalize(join(rootFolder, path))).toList(),
-      resourceProvider: PhysicalResourceProvider.INSTANCE,
-    );
+    final collection = createAnalysisContextCollection(folders, rootFolder);
 
     final unusedFiles = <String>{};
 

lib/src/utils/analyzer_utils.dart

@@ -0,0 +1,40 @@
+// ignore_for_file: implementation_imports
+import 'package:analyzer/dart/analysis/analysis_context_collection.dart';
+import 'package:analyzer/file_system/physical_file_system.dart';
+import 'package:analyzer/src/dart/analysis/analysis_context_collection.dart';
+import 'package:analyzer/src/dart/analysis/byte_store.dart';
+import 'package:analyzer/src/dart/analysis/file_byte_store.dart';
+import 'package:path/path.dart';
+
+AnalysisContextCollection createAnalysisContextCollection(
+  Iterable<String> folders,
+  String rootFolder,
+) {
+  final resourceProvider = PhysicalResourceProvider.INSTANCE;
+
+  return AnalysisContextCollectionImpl(
+    includedPaths:
+        folders.map((path) => normalize(join(rootFolder, path))).toList(),
+    resourceProvider: resourceProvider,
+    byteStore: _createByteStore(resourceProvider),
+  );
+}
+
+/// If the state location can be accessed, return the file byte store,
+/// otherwise return the memory byte store.
+ByteStore _createByteStore(PhysicalResourceProvider resourceProvider) {
+  const M = 1024 * 1024 /*1 MiB*/;
+  const G = 1024 * 1024 * 1024 /*1 GiB*/;
+
+  const memoryCacheSize = M * 128;
+
+  final stateLocation = resourceProvider.getStateLocation('.dart-code-metrics');
+  if (stateLocation != null) {
+    return MemoryCachingByteStore(
+      EvictingFileByteStore(stateLocation.path, G),
+      memoryCacheSize,
+    );
+  }
+
+  return MemoryCachingByteStore(NullByteStore(), memoryCacheSize);
+}