Skip to content

Commit 974f0dc

Browse files
committed
clarify comments
1 parent ac8d287 commit 974f0dc

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

api/api.go

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -938,13 +938,7 @@ func (m *ApiService) processSingleValidator(idx int, valPubKey string, resultsCh
938938
return
939939
}
940940

941-
// If the validator is or has been registered, the relayer will return a 200 message
942-
// with the signed registration message. If the validator has never been registered,
943-
// the relayer will return code 400 or 404 (depending on the relay) with the following message:
944-
// {
945-
// "code": 404,
946-
// "message": "no registration found for validator 0xafcdacfb67396a41a72676f3b064bcf62e977e5ef1d8aebadeed06e97156d4f640516fb205d12211ada9a54fcc26cc58"
947-
// }
941+
// If the validator is or has been registered, the relayer will return a 200 message with the signed registration message.
948942
// https://flashbots.github.io/relay-specs/#/Data/getValidatorRegistration
949943
if resp.StatusCode == http.StatusOK {
950944
signedRegistration := &builderApiV1.SignedValidatorRegistration{}
@@ -963,25 +957,20 @@ func (m *ApiService) processSingleValidator(idx int, valPubKey string, resultsCh
963957
Timestamp: fmt.Sprintf("%d", signedRegistration.Message.Timestamp.UnixNano()),
964958
}
965959

966-
// If the fee recipient matches the pool address, the relayer is registered
960+
// If the fee recipient matches the pool address, the relayer is registered with the correct fee recipient (the smoothing pool one)
967961
if utils.Equals(signedRegistration.Message.FeeRecipient.String(), m.Onchain.PoolAddress) {
968962
correctFeeRelays = append(correctFeeRelays, relayRegistration)
969963
} else {
970964
// if the fee recipient does not match the pool address, the relayer is registered but with the wrong fee recipient
971965
wrongFeeRelays = append(wrongFeeRelays, relayRegistration)
972966
}
973967

974-
// else if (signedRegistration.Message.FeeRecipient.String() != m.Onchain.PoolAddress) && (signedRegistration.Message.FeeRecipient.String() != "") {
975-
// // If the fee recipient does not match the pool address, the relayer is registered but with the wrong fee recipient
976-
// wrongFeeRelays = append(wrongFeeRelays, relayRegistration)
977-
// }
978-
979968
} else if resp.StatusCode == http.StatusBadRequest || resp.StatusCode == http.StatusNotFound {
980-
// the validator is not registered with the relayer
969+
// If the validator has never been registered, the relayer will return code 400 or 404 (depending on the relay)
981970
unregisteredRelays = append(unregisteredRelays, httpRelay{RelayAddress: relay})
982971
} else {
983-
// there was an error calling the relayer, so we couldnt check if the validator is/was registered with the correct
984-
// fee recipient, so we return an error.
972+
// If we get here, the relayer had an internal server error, so we couldnt check if the validator is/was registered with the correct
973+
// fee recipient. We return an error.
985974
resultsChan <- ValidatorRelayResult{
986975
Index: idx,
987976
Err: fmt.Errorf("error calling relayer %s for validator %s: %v", relay, valPubKey, string(bodyBytes)),

0 commit comments

Comments
 (0)