Skip to content

Use official sources #15

@sneurlax

Description

@sneurlax

Use EpicCash/epic-wallet instead of cypherstack/epic-wallet

Today's change in impls/src/adapters/epicbox.rs may be able to be circumvented by passing the epicbox domain to EpicboxBroker::post_slate as part of the address parameter (if the address isn't limited or validated to exclude it)

Using official sources would:

  • Remove a source of doubt in users' minds: they're using official code, they don't have to trust CypherStack
  • Remove a potential point of failure in a supply chain attack
  • Reduce the amount of times we have to publish a crate
  • Reduce the differences in comparisons between commits, branches, and forks because of stack_ prefixes

But there could be plenty of other issues with using official sources which lead to the choice to vendor and prefix epic-wallet.

Update 24-03-01:

The following crates were updated persuant to Epic Wallet's recent change from #40:

  • stack_epic_api
  • stack_epic_chain
  • stack_epic_core
  • stack_epic_keychain
  • stack_epic_p2p
  • stack_epic_pool
  • stack_epic_store
  • stack_epic_util
  • stack_epic_wallet_api
  • stack_epic_wallet_config
  • stack_epic_wallet_controller
  • stack_epic_wallet_impls
  • stack_epic_wallet_libwallet
  • and stack_epic_wallet_util

There may be more stack_epic_* packages, just doublecheck if we can point to the official epic_* crates, and if not, then we need to get these custom crates into source control

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions