Fix crash in jsonexpr command line tool when no argument provided

cschreib · cschreib · commit 38100f860c57 · 2024-09-04T10:56:31.000+01:00
diff --git a/jsonexpr/src/main.cpp b/jsonexpr/src/main.cpp
@@ -34,8 +34,11 @@ int main(int argc, const char* argv[]) {
         for (const auto& [key, value] : data.items()) {
             vars[key] = value;
         }
-    } else {
+    } else if (argc == 2) {
         expression = argv[1];
+    } else {
+        std::cerr << "error: no expression provided" << std::endl;
+        return 1;
     }
 
     const auto result = jsonexpr::evaluate(expression, vars, funcs);

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,11 @@ int main(int argc, const char* argv[]) {`
`34`	`34`	`for (const auto& [key, value] : data.items()) {`
`35`	`35`	`vars[key] = value;`
`36`	`36`	`}`
`37`		`- } else {`
	`37`	`+ } else if (argc == 2) {`
`38`	`38`	`expression = argv[1];`
	`39`	`+ } else {`
	`40`	`+ std::cerr << "error: no expression provided" << std::endl;`
	`41`	`+ return 1;`
`39`	`42`	`}`
`40`	`43`
`41`	`44`	`const auto result = jsonexpr::evaluate(expression, vars, funcs);`